From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v21 11/14] x86/VPMU: Handle PMU interrupts for PV(H) guests Date: Mon, 18 May 2015 12:19:04 -0400 Message-ID: <555A10F8.6060503@oracle.com> References: <1431119174-1947-1-git-send-email-boris.ostrovsky@oracle.com> <1431119174-1947-12-git-send-email-boris.ostrovsky@oracle.com> <555A23ED020000780007B479@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <555A23ED020000780007B479@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com, tim@xen.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, jun.nakajima@intel.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On 05/18/2015 11:39 AM, Jan Beulich wrote: >>>> On 08.05.15 at 23:06, wrote: >> --- a/xen/arch/x86/hvm/svm/vpmu.c >> +++ b/xen/arch/x86/hvm/svm/vpmu.c >> @@ -45,6 +45,7 @@ static unsigned int __read_mostly num_counters; >> static const u32 __read_mostly *counters; >> static const u32 __read_mostly *ctrls; >> static bool_t __read_mostly k7_counters_mirrored; >> +static unsigned long __read_mostly ctxt_sz; > Can this reasonably require a long instead of just an int? This is assigned by sizeof() so perhaps it should rather be size_t (which is an unsigned long)? But I can guarantee that it will fit into an int ;-) -boris