From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuOSZ-0007wF-SC for qemu-devel@nongnu.org; Mon, 18 May 2015 13:04:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuOSX-00059X-67 for qemu-devel@nongnu.org; Mon, 18 May 2015 13:04:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58432 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuOSW-00059T-Vn for qemu-devel@nongnu.org; Mon, 18 May 2015 13:04:09 -0400 Message-ID: <555A1B86.5060107@suse.de> Date: Mon, 18 May 2015 19:04:06 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1431956400-19091-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1431956400-19091-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] target-s390x: fix CC computation for LOAD POSITIVE instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno , qemu-devel@nongnu.org Cc: Richard Henderson On 05/18/2015 03:39 PM, Aurelien Jarno wrote: > LOAD POSITIVE instructions (LPR, LPGR and LPGFR) set the following > condition code: > 0: Result zero; no overflow > 1: -- > 2: Result greater than zero; no overflow > 3: Overflow > > The current code wrongly returns 1 instead of 2 in case of a result > greater than 0. This patches fixes that. This fixes the marshalling of > the value '0L' in Python. > > Cc: Richard Henderson > Cc: Alexander Graf > Signed-off-by: Aurelien Jarno Thanks, applied all to s390-next. Alex