From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/4] x86: move syscall trampolines off the
 stack
Date: Mon, 18 May 2015 19:39:57 +0100
Message-ID: <555A31FD.3030706@citrix.com>
References: <5559DAFF020000780007AFE2@mail.emea.novell.com>
	<5559FB2E020000780007B196@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1YuPxX-0001nx-Ua
	for xen-devel@lists.xenproject.org; Mon, 18 May 2015 18:40:16 +0000
In-Reply-To: <5559FB2E020000780007B196@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 18/05/15 13:46, Jan Beulich wrote:
> This is needed as stacks are going to become non-executable. Use
> separate stub pages (shared among suitable CPUs on the same node)
> instead.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Can you please include a description of how you intend the stubs to
function, and how they are layed out?  Parts of the code look like a
single page per stub, while other bits look like several stubs per page.

(Personally, I would split the stub allocation/mapping/freeing into a
patch separately to moving the syscall trampolines, as each are
moderately complicated changes.)

~Andrew