All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, arei.gonglei@huawei.com,
	mrhines@us.ibm.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 00/10] Remove RDMA migration dependence on RAMBlock offset
Date: Mon, 18 May 2015 17:01:58 -0500	[thread overview]
Message-ID: <555A6156.7040606@linux.vnet.ibm.com> (raw)
In-Reply-To: <1429545445-28216-1-git-send-email-dgilbert@redhat.com>

On 04/20/2015 10:57 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> RDMA migration currently relies on the source and destination RAMBlocks
> having the same offsets within ram_addr_t space;  unfortunately that's
> just not true when:
>     a) You hotplug on the source but then create the device on the command line
>       on the destination.
>
>     b) Across two versions of qemu
>
> Thus there are migrations that work with TCP that don't with RDMA.
>
> The changes keep stream compatibility with existing RDMA migration,
> so cases that already work (i.e. no hotplug) will keep working.
>
> With some light testing this seems to work; hopefully I've got all the
> cases that pass offsets back and forward.
>
> Dave
>
> Dr. David Alan Gilbert (10):
>    Rename RDMA structures to make destination clear
>    qemu_ram_foreach_block: pass up error value, and down the ramblock
>      name
>    Store block name in local blocks structure
>    Translate offsets to destination address space
>    Rework ram_control_load_hook to hook during block load
>    Remove unneeded memset
>    Simplify rdma_delete_block and remove it's dependence on the hash
>    Rework ram block hash
>    Sort destination RAMBlocks to be the same as the source
>    Sanity check RDMA remote data
>
>   arch_init.c                   |   4 +-
>   exec.c                        |  10 +-
>   include/exec/cpu-common.h     |   4 +-
>   include/migration/migration.h |   2 +-
>   include/migration/qemu-file.h |  14 +-
>   migration/qemu-file.c         |   8 +-
>   migration/rdma.c              | 367 ++++++++++++++++++++++++++----------------
>   trace-events                  |   8 +-
>   8 files changed, 257 insertions(+), 160 deletions(-)
>

OK, I've got the patchset open now on my new office in the US.

Getting ready to go through it..........

- Michael

      parent reply	other threads:[~2015-05-18 22:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 15:57 [Qemu-devel] [PATCH 00/10] Remove RDMA migration dependence on RAMBlock offset Dr. David Alan Gilbert (git)
2015-04-20 15:57 ` [Qemu-devel] [PATCH 01/10] Rename RDMA structures to make destination clear Dr. David Alan Gilbert (git)
2015-05-19 17:52   ` Michael R. Hines
2015-04-20 15:57 ` [Qemu-devel] [PATCH 02/10] qemu_ram_foreach_block: pass up error value, and down the ramblock name Dr. David Alan Gilbert (git)
2015-05-19 17:56   ` Michael R. Hines
2015-04-20 15:57 ` [Qemu-devel] [PATCH 03/10] Store block name in local blocks structure Dr. David Alan Gilbert (git)
2015-05-19 18:00   ` Michael R. Hines
2015-05-19 18:46     ` Dr. David Alan Gilbert
2015-04-20 15:57 ` [Qemu-devel] [PATCH 04/10] Translate offsets to destination address space Dr. David Alan Gilbert (git)
2015-05-19 18:28   ` Michael R. Hines
2015-05-19 18:44     ` Dr. David Alan Gilbert
2015-05-19 18:57       ` Michael R. Hines
2015-05-19 19:02         ` Dr. David Alan Gilbert
2015-04-20 15:57 ` [Qemu-devel] [PATCH 05/10] Rework ram_control_load_hook to hook during block load Dr. David Alan Gilbert (git)
2015-05-19 18:35   ` Michael R. Hines
2015-05-19 18:49     ` Dr. David Alan Gilbert
2015-04-20 15:57 ` [Qemu-devel] [PATCH 06/10] Remove unneeded memset Dr. David Alan Gilbert (git)
2015-05-19 18:35   ` Michael R. Hines
2015-04-20 15:57 ` [Qemu-devel] [PATCH 07/10] Simplify rdma_delete_block and remove it's dependence on the hash Dr. David Alan Gilbert (git)
2015-05-19 18:44   ` Michael R. Hines
2015-04-20 15:57 ` [Qemu-devel] [PATCH 08/10] Rework ram block hash Dr. David Alan Gilbert (git)
2015-05-19 18:49   ` Michael R. Hines
2015-05-19 18:55     ` Dr. David Alan Gilbert
2015-05-19 19:02       ` Michael R. Hines
2015-05-19 19:07         ` Dr. David Alan Gilbert
2015-04-20 15:57 ` [Qemu-devel] [PATCH 09/10] Sort destination RAMBlocks to be the same as the source Dr. David Alan Gilbert (git)
2015-05-19 18:51   ` Michael R. Hines
2015-06-01 11:53     ` Dr. David Alan Gilbert
2015-04-20 15:57 ` [Qemu-devel] [PATCH 10/10] Sanity check RDMA remote data Dr. David Alan Gilbert (git)
2015-05-19 18:52   ` Michael R. Hines
2015-05-18 22:01 ` Michael R. Hines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555A6156.7040606@linux.vnet.ibm.com \
    --to=mrhines@linux.vnet.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=dgilbert@redhat.com \
    --cc=mrhines@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.