All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: Eduardo Espejo <eduardo.espejo@gmail.com>
Subject: Re: [PATCH] daemon: unbreak NO_IPV6 build regression
Date: Tue, 19 May 2015 00:29:40 +0200	[thread overview]
Message-ID: <555A67D4.9040204@web.de> (raw)
In-Reply-To: <xmqqd22eew4v.fsf_-_@gitster.dls.corp.google.com>

Am 05.05.2015 um 20:07 schrieb Junio C Hamano:
> When 01cec54e (daemon: deglobalize hostname information, 2015-03-07)
> wrapped the global variables such as hostname inside a struct, it
> forgot to convert one location that spelled "hostname" that needs to
> be updated to "hi->hostname".
>
> This was inside NO_IPV6 block, and was not caught by anybody.

Sorry for that, and thank you for cleaning up after me. :-/

@Eduardo: Out of interest, on which platform (CPU, operating system, 
compiler) did you notice the bug?

Thanks,
René

      reply	other threads:[~2015-05-18 22:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-05 14:20 [BUG] deamon.c does not compile when NO_IPV6 is used Eduardo Espejo
2015-05-05 17:55 ` Junio C Hamano
2015-05-05 18:07   ` [PATCH] daemon: unbreak NO_IPV6 build regression Junio C Hamano
2015-05-18 22:29     ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555A67D4.9040204@web.de \
    --to=l.s.r@web.de \
    --cc=eduardo.espejo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.