From: Shannon Zhao <zhaoshenglong@huawei.com>
To: David Gibson <david@gibson.dropbear.id.au>,
agraf@suse.de, mst@redhat.com, pbonzini@redhat.com,
peter.crosthwaite@xilinx.com
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCHv2 1/3] Add specific config options for PCI-E bridges
Date: Tue, 19 May 2015 10:40:11 +0800 [thread overview]
Message-ID: <555AA28B.8040801@huawei.com> (raw)
In-Reply-To: <1425017077-18487-2-git-send-email-david@gibson.dropbear.id.au>
Hi,
I'm testing PCIe root port (ioh3420) on ARM64. Firstly I use following
simple command line to check whether it works.
qemu-system-aarch64 -M virt -device ioh3420
But it fails with below log:
qemu-system-aarch64: -device ioh3420: Device initialization failed
qemu-system-aarch64: -device ioh3420: Device 'ioh3420' could not be
initialized
Is there something wrong with my command line? or ioh3420 can't be used
on ARM64? But from this patch and the discussions on it, it seems
ioh3420 should work on ARM64.
Thanks,
Shannon
On 2015/2/27 14:04, David Gibson wrote:
> The i82801b11, ioh3420 and xio3130 PCI Express devices are currently
> included in the build unconditionally.
>
> While they could theoretically appear on any target platform with PCI-E,
> they're pretty unlikely to appear on platforms that aren't Intel derived.
>
> Therefore, to avoid presenting unlikely-to-be-relevant devices to the user,
> add config options to enable these components, and enable them by default
> only on x86 and arm platforms.
>
> (Note that this patch does include these for aarch64, via its inclusion of
> arm-softmmu.mak).
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> default-configs/arm-softmmu.mak | 4 ++++
> default-configs/i386-softmmu.mak | 3 +++
> default-configs/x86_64-softmmu.mak | 3 +++
> hw/pci-bridge/Makefile.objs | 5 +++--
> 4 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index b00c2e1..6ee9b43 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -91,3 +91,7 @@ CONFIG_INTEGRATOR_DEBUG=y
> CONFIG_ALLWINNER_A10_PIT=y
> CONFIG_ALLWINNER_A10_PIC=y
> CONFIG_ALLWINNER_A10=y
> +
> +CONFIG_XIO3130=y
> +CONFIG_IOH3420=y
> +CONFIG_I82801B11=y
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index bd99af9..0b8ce4b 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -43,3 +43,6 @@ CONFIG_IOAPIC=y
> CONFIG_ICC_BUS=y
> CONFIG_PVPANIC=y
> CONFIG_MEM_HOTPLUG=y
> +CONFIG_XIO3130=y
> +CONFIG_IOH3420=y
> +CONFIG_I82801B11=y
> diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
> index e7c2734..6add04a 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -43,3 +43,6 @@ CONFIG_IOAPIC=y
> CONFIG_ICC_BUS=y
> CONFIG_PVPANIC=y
> CONFIG_MEM_HOTPLUG=y
> +CONFIG_XIO3130=y
> +CONFIG_IOH3420=y
> +CONFIG_I82801B11=y
> diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
> index 968b369..96c596e 100644
> --- a/hw/pci-bridge/Makefile.objs
> +++ b/hw/pci-bridge/Makefile.objs
> @@ -1,5 +1,6 @@
> common-obj-y += pci_bridge_dev.o
> -common-obj-y += ioh3420.o xio3130_upstream.o xio3130_downstream.o
> -common-obj-y += i82801b11.o
> +common-obj-$(CONFIG_XIO3130) += xio3130_upstream.o xio3130_downstream.o
> +common-obj-$(CONFIG_IOH3420) += ioh3420.o
> +common-obj-$(CONFIG_I82801B11) += i82801b11.o
> # NewWorld PowerMac
> common-obj-$(CONFIG_DEC_PCI) += dec.o
>
next prev parent reply other threads:[~2015-05-19 2:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 6:04 [Qemu-devel] [PATCHv2 0/3] Add config options for some not-always-sensible devices David Gibson
2015-02-27 6:04 ` [Qemu-devel] [PATCHv2 1/3] Add specific config options for PCI-E bridges David Gibson
2015-05-19 2:40 ` Shannon Zhao [this message]
2015-05-19 3:34 ` Shannon Zhao
2015-02-27 6:04 ` [Qemu-devel] [PATCHv2 2/3] Create specific config option for "platform-bus" David Gibson
2015-02-27 6:04 ` [Qemu-devel] [PATCHv2 3/3] Give ivshmem its own config option David Gibson
2015-02-27 14:18 ` [Qemu-devel] [PATCHv2 0/3] Add config options for some not-always-sensible devices Paolo Bonzini
2015-03-01 16:37 ` Michael S. Tsirkin
2015-03-02 4:55 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555AA28B.8040801@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=agraf@suse.de \
--cc=christoffer.dall@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.