From: Zefan Li <lizefan@huawei.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: xen-tools@packages.debian.org, xen-devel@lists.xensource.com,
stefano.stabellini@eu.citrix.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Al Viro <viro@ZenIV.linux.org.uk>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: "don't bugger nd->seq" seems to break umount sometimes
Date: Tue, 19 May 2015 17:05:46 +0800 [thread overview]
Message-ID: <555AFCEA.5020102@huawei.com> (raw)
In-Reply-To: <1432024439.12989.7.camel@citrix.com>
On 2015/5/19 16:33, Ian Campbell wrote:
> On Thu, 2015-04-30 at 09:15 +0800, Zefan Li wrote:
>> On 2015/4/29 20:21, Al Viro wrote:
>>> On Wed, Apr 29, 2015 at 12:45:45PM +0100, Ian Jackson wrote:
>>>
>>>> The symptoms are that `umount' fails with EBUSY,
>>>
>>> [lizf: Backported to 3.4:
>>> - remove the changes to follow_link() as it doesn't call set_root()]
>>>
>>> looks dubious - I don't have -stable in front of me, but set_root() in
>>> follow_link() had migrated from __vfs_follow_link(), so could you try
>>> (tr '#' '\t' | ed fs/namei.c) <<'EOF'
>>> /__vfs_follow_link/
>>> /set_root/s/^/#/
>>> i
>>> ##if (!nd->root.mnt)
>>> .
>>> wq
>>> EOF
>>> and see if it helps?
>>> .
>>>
>>
>> My fault. I just checked 3.2.y, and it made the right change.
>
> Is there going to be a 3.4.108 with a fix for this?
>
definitely.
next prev parent reply other threads:[~2015-05-19 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1YleTb-0005Ma-NN@osstest.test-lab.xenproject.org>
[not found] ` <21824.50281.405589.957467@mariner.uk.xensource.com>
2015-04-29 12:21 ` "don't bugger nd->seq" seems to break umount sometimes Al Viro
2015-04-30 1:15 ` Zefan Li
2015-05-19 8:33 ` Ian Campbell
2015-05-19 9:05 ` Zefan Li [this message]
2015-05-19 9:47 ` Ian Campbell
2015-05-19 10:33 ` Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555AFCEA.5020102@huawei.com \
--to=lizefan@huawei.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=xen-devel@lists.xensource.com \
--cc=xen-tools@packages.debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.