From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 19 May 2015 11:07:16 +0200 Subject: [PATCH 1/4] ARM: at91/dt: sama5d3 xplained: fill in mmc1 and set it to disabled In-Reply-To: <1430140753-19998-1-git-send-email-ludovic.desroches@atmel.com> References: <1430140753-19998-1-git-send-email-ludovic.desroches@atmel.com> Message-ID: <555AFD44.7040007@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 27/04/2015 15:19, Ludovic Desroches a ?crit : > From: Ben Dooks > > The mmc1 channel is not populated on the SAM5D3 Xplained board, however > it is enabled and therefore the driver is attaching to it. > > The node configuration for mmc1 is missing, so add an mmc1 node in the > device tree and set its status to disabled. Also add the vmmc and the > necessary slot configuration if this node were enabled to avoid the following > warnings from the driver: > > atmel_mci f8000000.mmc: No vmmc regulator found > atmel_mci f8000000.mmc: No vqmmc regulator found > > Signed-off-by: Ben Dooks > Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre and queued on at91-4.2-dt branch. I also sent the update of the at91 defconfigs. We may need to have a kind of synchronization between them... but a loose one should be okay... Bye, > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index 9991240..af8b263 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -43,6 +43,17 @@ > }; > }; > > + mmc1: mmc at f8000000 { > + vmmc-supply = <&vcc_3v3_reg>; > + vqmmc-supply = <&vcc_3v3_reg>; > + status = "disabled"; > + slot at 0 { > + reg = <0>; > + bus-width = <4>; > + cd-gpios = <&pioE 1 GPIO_ACTIVE_LOW>; > + }; > + }; > + > spi0: spi at f0004000 { > cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; > status = "okay"; > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 1/4] ARM: at91/dt: sama5d3 xplained: fill in mmc1 and set it to disabled Date: Tue, 19 May 2015 11:07:16 +0200 Message-ID: <555AFD44.7040007@atmel.com> References: <1430140753-19998-1-git-send-email-ludovic.desroches@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1430140753-19998-1-git-send-email-ludovic.desroches@atmel.com> Sender: linux-kernel-owner@vger.kernel.org To: Ludovic Desroches , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, ben.dooks@codethink.co.uk Cc: linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com, Alexandre Belloni , Boris BREZILLON List-Id: devicetree@vger.kernel.org Le 27/04/2015 15:19, Ludovic Desroches a =E9crit : > From: Ben Dooks >=20 > The mmc1 channel is not populated on the SAM5D3 Xplained board, howev= er > it is enabled and therefore the driver is attaching to it. >=20 > The node configuration for mmc1 is missing, so add an mmc1 node in th= e > device tree and set its status to disabled. Also add the vmmc and the > necessary slot configuration if this node were enabled to avoid the f= ollowing > warnings from the driver: >=20 > atmel_mci f8000000.mmc: No vmmc regulator found > atmel_mci f8000000.mmc: No vqmmc regulator found >=20 > Signed-off-by: Ben Dooks > Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre and queued on at91-4.2-dt branch. I also sent the update of the at91 defconfigs. We may need to have a kind of synchronization between them... but a loose one should be okay.= =2E. Bye, > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/b= oot/dts/at91-sama5d3_xplained.dts > index 9991240..af8b263 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -43,6 +43,17 @@ > }; > }; > =20 > + mmc1: mmc@f8000000 { > + vmmc-supply =3D <&vcc_3v3_reg>; > + vqmmc-supply =3D <&vcc_3v3_reg>; > + status =3D "disabled"; > + slot@0 { > + reg =3D <0>; > + bus-width =3D <4>; > + cd-gpios =3D <&pioE 1 GPIO_ACTIVE_LOW>; > + }; > + }; > + > spi0: spi@f0004000 { > cs-gpios =3D <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; > status =3D "okay"; >=20 --=20 Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755358AbbESJIR (ORCPT ); Tue, 19 May 2015 05:08:17 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:43235 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753121AbbESJIM (ORCPT ); Tue, 19 May 2015 05:08:12 -0400 Message-ID: <555AFD44.7040007@atmel.com> Date: Tue, 19 May 2015 11:07:16 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ludovic Desroches , , , CC: , , Alexandre Belloni , Boris BREZILLON Subject: Re: [PATCH 1/4] ARM: at91/dt: sama5d3 xplained: fill in mmc1 and set it to disabled References: <1430140753-19998-1-git-send-email-ludovic.desroches@atmel.com> In-Reply-To: <1430140753-19998-1-git-send-email-ludovic.desroches@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 27/04/2015 15:19, Ludovic Desroches a écrit : > From: Ben Dooks > > The mmc1 channel is not populated on the SAM5D3 Xplained board, however > it is enabled and therefore the driver is attaching to it. > > The node configuration for mmc1 is missing, so add an mmc1 node in the > device tree and set its status to disabled. Also add the vmmc and the > necessary slot configuration if this node were enabled to avoid the following > warnings from the driver: > > atmel_mci f8000000.mmc: No vmmc regulator found > atmel_mci f8000000.mmc: No vqmmc regulator found > > Signed-off-by: Ben Dooks > Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre and queued on at91-4.2-dt branch. I also sent the update of the at91 defconfigs. We may need to have a kind of synchronization between them... but a loose one should be okay... Bye, > --- > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index 9991240..af8b263 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -43,6 +43,17 @@ > }; > }; > > + mmc1: mmc@f8000000 { > + vmmc-supply = <&vcc_3v3_reg>; > + vqmmc-supply = <&vcc_3v3_reg>; > + status = "disabled"; > + slot@0 { > + reg = <0>; > + bus-width = <4>; > + cd-gpios = <&pioE 1 GPIO_ACTIVE_LOW>; > + }; > + }; > + > spi0: spi@f0004000 { > cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; > status = "okay"; > -- Nicolas Ferre