From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?J=FCrgen_Gro=DF?= Subject: Re: [PATCH V3 3/6] libxl: add pvusb API Date: Tue, 19 May 2015 13:31:53 +0200 Message-ID: <555B1F29.7000707@suse.com> References: <1429415452-6161-1-git-send-email-cyliu@suse.com> <1429415452-6161-4-git-send-email-cyliu@suse.com> <20150518180724.GH9503@zion.uk.xensource.com> <555B1C8B02000066000C774B@relay2.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , Chun Yan Liu Cc: Lars Kurth , Wei Liu , Ian Campbell , "xen-devel@lists.xen.org" , Ian Jackson , Simon Cao List-Id: xen-devel@lists.xenproject.org On 05/19/2015 12:20 PM, George Dunlap wrote: > On Tue, May 19, 2015 at 4:20 AM, Chun Yan Liu wrote: >>> >>>> +static int libxl__device_usbctrl_setdefault(libxl__gc *gc, uint32_t domid, >>>> + libxl_device_usbctrl *usbctrl) >>>> +{ >>>> + int rc; >>>> + >>>> + if (!usbctrl->version) >>>> + usbctrl->version = 2; >>>> + >>> >>> How hard would it be to implement USB 3? I assume this depends on QEMU's >>> support? I.e. we just need to specify the version to 3 and it should >>> just work? Just curious. >> >> This implementation is coworked with PVUSB driver, so it depends on PVUSB >> driver's support. If PVUSB driver supports that, just specify the version to 3 and >> can work. > > I sort of got the idea that from the pvusb driver's perspective, the > 1/2/3 thing was mostly just a number -- one that's important to the > USB device itself and the USB driver for those devices in the guest, > but less so for the pvusb layer. Is that not the case? I think at least for support of USB3.0 streams there is some work to do. I haven't done any thorough research on this topic, but as libusb had to be changed for support of USB3.0 as well, I'd expect this to be the case for the pvusb interface, too. Juergen