From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.ostrovsky@oracle.com (Boris Ostrovsky) Date: Tue, 19 May 2015 10:49:20 -0400 Subject: [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS In-Reply-To: <2292282.A4UNIrHzbV@wuerfel> References: <3837965.uXvcfKiP40@wuerfel> <555B413F.7020509@oracle.com> <2292282.A4UNIrHzbV@wuerfel> Message-ID: <555B4D70.7050900@oracle.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/19/2015 10:36 AM, Arnd Bergmann wrote: > On Tuesday 19 May 2015 09:57:19 Boris Ostrovsky wrote: >> On 05/19/2015 08:58 AM, Arnd Bergmann wrote: >>> A recent bug fix for x86 broke Xen on ARM for the case that >>> CONFIG_HIBERNATE_CALLBACKS is enabled: >>> >>> drivers/built-in.o: In function `do_suspend': >>> /git/arm-soc/drivers/xen/manage.c:134: undefined reference to `xen_arch_suspend' >>> drivers/built-in.o:(.debug_addr+0xc3f4): undefined reference to `xen_arch_suspend' >>> >>> It is not clear to me what needs to be done here, but this >>> patch avoids the build error by adding a stub for the >>> missing function. >> This is already fixed in Xen staging tree. > I see. Any chance to get that fix into linux-next soon? David, are you going to send pull request to Linus before rc5? -boris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933584AbbESOwR (ORCPT ); Tue, 19 May 2015 10:52:17 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28549 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932353AbbESOwP (ORCPT ); Tue, 19 May 2015 10:52:15 -0400 Message-ID: <555B4D70.7050900@oracle.com> Date: Tue, 19 May 2015 10:49:20 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnd Bergmann , David Vrabel CC: Stefano Stabellini , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen: fix building on ARM with CONFIG_HIBERNATE_CALLBACKS References: <3837965.uXvcfKiP40@wuerfel> <555B413F.7020509@oracle.com> <2292282.A4UNIrHzbV@wuerfel> In-Reply-To: <2292282.A4UNIrHzbV@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2015 10:36 AM, Arnd Bergmann wrote: > On Tuesday 19 May 2015 09:57:19 Boris Ostrovsky wrote: >> On 05/19/2015 08:58 AM, Arnd Bergmann wrote: >>> A recent bug fix for x86 broke Xen on ARM for the case that >>> CONFIG_HIBERNATE_CALLBACKS is enabled: >>> >>> drivers/built-in.o: In function `do_suspend': >>> /git/arm-soc/drivers/xen/manage.c:134: undefined reference to `xen_arch_suspend' >>> drivers/built-in.o:(.debug_addr+0xc3f4): undefined reference to `xen_arch_suspend' >>> >>> It is not clear to me what needs to be done here, but this >>> patch avoids the build error by adding a stub for the >>> missing function. >> This is already fixed in Xen staging tree. > I see. Any chance to get that fix into linux-next soon? David, are you going to send pull request to Linus before rc5? -boris