From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 95E5FE00A16; Tue, 19 May 2015 08:17:39 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.182 listed in list.dnswl.org] Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id F1223E004F6 for ; Tue, 19 May 2015 08:16:47 -0700 (PDT) Received: by wicmc15 with SMTP id mc15so120920221wic.1 for ; Tue, 19 May 2015 08:16:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=fKK9Qro9yEaGJm+JxnpqmVZXuW6JNvnIxf2Dhyq2Y4A=; b=G/j6PXDg/urrs89F9ZCxo3HwefORX1iQoQRT6U26Nr474B3rxKlvK94NCIyRWP4+/h oD/s0Uty8HUAA2Ip2+EZ2dYnAtT8Al+ptiNozUHHMb/e8yhMvfVmH1sFkxtT1C4TW1+5 aX1Ab2EKxqJFPRLbyTCCdNmdId+cP7ACW4iSD9nu5hi5P0b9TXqejS/B2pBmdswdALaJ 2x+BsWhNYgGNIvR2OMUFWtwaVLQNcpt2K/g0VM5EVzCDnbWU3nKCGzww04byOn6i7cDr /IC1ERazf/6uoM+tmolSl6t0rONoaqSYdyCzPG/TDNoWs0N0IxscpAZ0JHKQ8MwvYaLd AHHw== X-Gm-Message-State: ALoCoQnD7ZJqPbnufYZ4zjY5IuCccOdYSKOdbpgqhKWQqt66sQ+D7y5rLSXHEKe1gFOnUqcvJOif X-Received: by 10.180.208.7 with SMTP id ma7mr33569522wic.0.1432048606463; Tue, 19 May 2015 08:16:46 -0700 (PDT) Received: from [192.168.2.36] ([83.217.123.106]) by mx.google.com with ESMTPSA id dj7sm22258975wjb.3.2015.05.19.08.16.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 May 2015 08:16:45 -0700 (PDT) Message-ID: <555B53DC.9030902@intel.com> Date: Tue, 19 May 2015 16:16:44 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <555A3E94.8040603@intel.com> <555B2F33.5000400@intel.com> In-Reply-To: Subject: Re: [review-request] michaelw/porting-layerdetails-tables X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 15:17:39 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit v2 pushed Note I've fixed a caching issue I spotted Full list of commits for review: commit 096423c4375b6d628b4eb408bbdab6411bd16715 Author: Michael Wood Date: Tue May 19 16:10:19 2015 +0100 bitbake: toaster: Add an invalidate cache method on data update signal Instead of relying on the cache expiring over an amount of time we can listen to the changed notification on the models to invalidate the cache. Also fixes overlapping cache names. Signed-off-by: Michael Wood commit 17d07ac77e411de5c8dd4e6b216330d766bde34a Author: Michael Wood Date: Mon May 18 20:08:28 2015 +0100 bitbake: toaster: Port layerdetails to ToasterTables This ports the layerdetails page to using ToasterTables Also some whitespace and strict clean ups in the existing layerdetails js and html template. Signed-off-by: Michael Wood commit 34a6159e14da621e356ccd6ec56059ef6a685583 Author: Michael Wood Date: Mon May 18 20:01:44 2015 +0100 bitbake: toaster: Add a simplified ToasterTable template This is like the normal ToasterTable template but with a number of features removed such as edit columns and has a lower profile compared to the "main" tables. Signed-off-by: Michael Wood commit 48931980173e4f69ec24c246b6b8b6a9ee9b0ed8 Author: Michael Wood Date: Mon May 18 13:44:53 2015 +0100 bitbake: toaster: Fix toastertable header Fixes regression introduced by 'tables updates for HTML5 compliance' Signed-off-by: Michael Wood On 19/05/15 13:49, Barros Pena, Belen wrote: > > On 19/05/2015 13:40, "Michael Wood" wrote: > >> On 19/05/15 12:34, Barros Pena, Belen wrote: >>> Looking pretty good. Only one comment: these tables should only show >>> search and show rows menu if they have more than 10 entries. >> Is that feature wanted for both kinds of the table? > No, only the ones in the 'details' pages (recipe details, package details, > layer details kind of thing). So this is not needed in the higher level > tables (all layers, all packages, all recipes, all tasks, all compatible > layers, all compatible recipes, all compatible machines and so on). > Although the higher level tables pretty much always have more than 10 > entries, so I guess if you implement the logic in both the practical > implications are negligible. If that's easier, go for it. > >> And that's if a search or filter is not currently applied right? > Yes, indeed. > >> >>> Thanks! >>> >>> Belén >>> >>> On 18/05/2015 20:33, "Michael Wood" wrote: >>> >>>> Squeezed in a few clean ups into this as well. >>>> >>>> commit 347aa8fd766f5fa0bd720ba9528dc006a59f7a47 >>>> Author: Michael Wood >>>> Date: Mon May 18 20:08:28 2015 +0100 >>>> >>>> bitbake: toaster: Port layerdetails to ToasterTables >>>> >>>> This ports the layerdetails page to using ToasterTables >>>> Also some whitespace and strict clean ups in the existing >>>> layerdetails >>>> js and html template. >>>> >>>> Signed-off-by: Michael Wood >>>> >>>> commit ebf6b73f4dcb1eeb6a77a3a921dd6dc2693f64f1 >>>> Author: Michael Wood >>>> Date: Mon May 18 20:01:44 2015 +0100 >>>> >>>> bitbake: toaster: Add a simplified ToasterTable template >>>> >>>> This is like the normal ToasterTable template but with a number of >>>> features removed such as edit columns and has a lower profile >>>> compared >>>> to the "main" tables. >>>> >>>> Signed-off-by: Michael Wood >>>> >>>> >>>> >>>> -- >>>> _______________________________________________ >>>> toaster mailing list >>>> toaster@yoctoproject.org >>>> https://lists.yoctoproject.org/listinfo/toaster