All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sébastien Guimmara" <sebastien.guimmara@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git Users <git@vger.kernel.org>
Subject: Re: [PATCH v8 5/5] help: respect new common command grouping
Date: Tue, 19 May 2015 19:57:48 +0200	[thread overview]
Message-ID: <555B799C.3000606@gmail.com> (raw)
In-Reply-To: <xmqqr3qda7kx.fsf@gitster.dls.corp.google.com>

On 05/18/2015 11:39 PM, Junio C Hamano wrote:
> I cannot exactly pinpoint what bothers me, but "The typical Git
> workflow includes:" sounds a bit awkward.
>
> What does a workflow "include"?  What are components included in a
> workflow?  Are "starting a repository", "working on a single thing",
> "collabolating", etc. components that are incuded in a workflow?
>
> If so, the fact that "clone", "init", etc. are "commands that are
> commonly used in each component of the workflow" is a more important
> thing to say; in other words, the header does not explain what list
> it is presenting the user.
>
> Or does a workflow consists of "clone", "init", "add", "mv", etc.
> that are included in it?  Then it is left unexplained what the
> section headings stand for.
>
> Perhaps something like
>
> 	These are common Git commands used in various situations:
>
> may lessen the uneasiness I felt above.  I dunno.

This sounds better indeed.

>
> Other than that, this round looks ready for 'next'.
>
> I am not absolutely sure if new dependency on "awk" will not present
> portability issues, though.  So far we only used it in scripts in
> the fringes and only a few tests.
>
> Thanks.
>

We can use Eric's perl version instead of the awk one.

Should I make another series or amend this one ?

Thank you.

      parent reply	other threads:[~2015-05-19 17:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 19:18 [PATCH v8 0/5] group common commands by theme Sébastien Guimmara
2015-05-18 19:18 ` [PATCH v8 1/5] command-list: prepare machinery for upcoming "common groups" section Sébastien Guimmara
2015-05-18 19:18 ` [PATCH v8 2/5] command-list.txt: add the common groups block Sébastien Guimmara
2015-05-18 19:18 ` [PATCH v8 3/5] generate-cmdlist: parse common group commands Sébastien Guimmara
2015-05-18 19:18 ` [PATCH v8 4/5] command-list.txt: drop the "common" tag Sébastien Guimmara
2015-05-18 19:18 ` [PATCH v8 5/5] help: respect new common command grouping Sébastien Guimmara
2015-05-18 21:39   ` Junio C Hamano
2015-05-19  0:43     ` Eric Sunshine
2015-05-19 16:09       ` Junio C Hamano
2015-05-19 16:35         ` Eric Sunshine
2015-05-19 18:20           ` Junio C Hamano
2015-05-19 17:57     ` Sébastien Guimmara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555B799C.3000606@gmail.com \
    --to=sebastien.guimmara@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.