[PATCH] clk: fix output format of debugfs/clk_dump

[PATCH] clk: fix output format of debugfs/clk_dump

[Vladimir Zapolskiy]

The output format of $(cat /sys/kernel/debug/clk/clk_dump) was
compliant to JSON and Python dictionary type some time ago, but at the
moment a couple of commas are missing, fix it.

Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
---
 drivers/clk/clk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 459ce9d..30be5fb 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -233,8 +233,8 @@ static void clk_dump_one(struct seq_file *s, struct clk_core *c, int level)
 	seq_printf(s, "\"%s\": { ", c->name);
 	seq_printf(s, "\"enable_count\": %d,", c->enable_count);
 	seq_printf(s, "\"prepare_count\": %d,", c->prepare_count);
-	seq_printf(s, "\"rate\": %lu", clk_core_get_rate(c));
-	seq_printf(s, "\"accuracy\": %lu", clk_core_get_accuracy(c));
+	seq_printf(s, "\"rate\": %lu,", clk_core_get_rate(c));
+	seq_printf(s, "\"accuracy\": %lu,", clk_core_get_accuracy(c));
 	seq_printf(s, "\"phase\": %d", clk_core_get_phase(c));
 }
 
-- 
2.1.4

Re: [PATCH] clk: fix output format of debugfs/clk_dump

[Stephen Boyd]

On 05/19/15 08:42, Vladimir Zapolskiy wrote:
> The output format of $(cat /sys/kernel/debug/clk/clk_dump) was
> compliant to JSON and Python dictionary type some time ago, but at the
> moment a couple of commas are missing, fix it.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>

Isn't this already fixed in clk-next with 7cb81136d2ef (clk: Fix JSON
output in debugfs, 2015-04-29)?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] clk: fix output format of debugfs/clk_dump

[Vladimir Zapolskiy]

On 19.05.2015 23:26, Stephen Boyd wrote:
> On 05/19/15 08:42, Vladimir Zapolskiy wrote:
>> The output format of $(cat /sys/kernel/debug/clk/clk_dump) was
>> compliant to JSON and Python dictionary type some time ago, but at the
>> moment a couple of commas are missing, fix it.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> 
> Isn't this already fixed in clk-next with 7cb81136d2ef (clk: Fix JSON
> output in debugfs, 2015-04-29)?
> 

Ah, great, I overlooked it, thank you for pointing it out, please ignore
my change.

--
With best wishes,
Vladimir