Re: [V4, 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

[Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>]

Hi Kamal,

There's one change still missing (that I mentioned when reviewing v2 of 
the patchset):

 >>>
What is the max len that can be supported? BSC_CNT_REG1_MASK = 63? Then
you should check against that.

Note Wolfram has introduced a way to validate the supported data length
at the i2c-core, which you should adapt:

commit b7f625840267b18ef1011cba0085bb7e237d76f7
Author: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Date:   Mon Jan 5 23:45:59 2015 +0100

     i2c: add quirk checks to core

     Let the core do the checks if HW quirks prevent a transfer. Saves code
     from drivers and adds consistency.
<<<

So you should add struct i2c_adapter_quirks and set the max_read_len and 
max_write_len.

I have no more comment for the rest of the code.

Thanks,

Ray