From: Alexei Starovoitov <ast@plumgrid.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org
Cc: Daniel Borkmann <borkmann@iogearbox.net>,
Robert Olsson <robert@herjulf.se>,
Ben Greear <greearb@candelatech.com>
Subject: Re: [net-next PATCH 04/10] pktgen: document ability to add same device to several threads
Date: Tue, 19 May 2015 14:54:13 -0700 [thread overview]
Message-ID: <555BB105.8060307@plumgrid.com> (raw)
In-Reply-To: <20150519213548.9070.25035.stgit@ivy>
On 5/19/15 2:35 PM, Jesper Dangaard Brouer wrote:
> The pktgen.txt documentation still claimed that adding same device to
> multiple threads were not supported, but it have been since 2008 via
> commit e6fce5b916cd7 ("pktgen: multiqueue etc.").
>
> Document this and describe the naming scheme dev@X, as the procfile name
> still need to be unique.
>
> Fixes: e6fce5b916cd7 ("pktgen: multiqueue etc.")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
...
> -Most important are the devices assigned to the thread. Note that a
> -device can only belong to one thread.
> +The two basic thread commands are:
> + * add_device DEVICE@NAME -- adds a single device
Great work for the whole series!
Wanted to specifically
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
this patch, since it could have saved me days of pointlessly
reimplementing existing feature and likely will help others
in the future. People do read docs :)
next prev parent reply other threads:[~2015-05-19 21:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 21:35 [net-next PATCH 00/10] pktgen: cleanups and introducing new samples/pktgen scripts Jesper Dangaard Brouer
2015-05-19 21:35 ` [net-next PATCH 01/10] pktgen: remove obsolete "max_before_softirq" from pktgen doc Jesper Dangaard Brouer
2015-05-19 21:35 ` [net-next PATCH 02/10] pktgen: adjust spacing in proc file interface output Jesper Dangaard Brouer
2015-05-19 21:35 ` [net-next PATCH 03/10] pktgen: doc were missing several config options Jesper Dangaard Brouer
2015-05-19 21:35 ` [net-next PATCH 04/10] pktgen: document ability to add same device to several threads Jesper Dangaard Brouer
2015-05-19 21:54 ` Alexei Starovoitov [this message]
2015-05-19 21:35 ` [net-next PATCH 05/10] pktgen: make /proc/net/pktgen/pgctrl report fail on invalid input Jesper Dangaard Brouer
2015-05-19 21:36 ` [net-next PATCH 06/10] pktgen: new pktgen helper functions for samples scripts Jesper Dangaard Brouer
2015-05-20 21:23 ` Cong Wang
2015-05-21 9:18 ` Jesper Dangaard Brouer
2015-05-19 21:36 ` [net-next PATCH 07/10] pktgen: add sample script pktgen_sample01_simple.sh Jesper Dangaard Brouer
2015-05-19 21:36 ` [net-next PATCH 08/10] pktgen: add sample script pktgen_sample02_multiqueue.sh Jesper Dangaard Brouer
2015-05-19 21:36 ` [net-next PATCH 09/10] pktgen: add sample script pktgen_sample03_burst_single_flow.sh Jesper Dangaard Brouer
2015-05-20 21:33 ` Cong Wang
2015-05-21 9:47 ` Jesper Dangaard Brouer
2015-05-19 21:36 ` [net-next PATCH 10/10] pktgen: add benchmark script pktgen_bench_xmit_mode_netif_receive.sh Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555BB105.8060307@plumgrid.com \
--to=ast@plumgrid.com \
--cc=borkmann@iogearbox.net \
--cc=brouer@redhat.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=robert@herjulf.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.