From mboxrd@z Thu Jan 1 00:00:00 1970 From: acourbot@nvidia.com (Alexandre Courbot) Date: Wed, 20 May 2015 09:33:46 +0900 Subject: [PATCH] drm/nouveau/platform: add IOMMU dependency In-Reply-To: <2918377.0irYYn09PU@wuerfel> References: <2918377.0irYYn09PU@wuerfel> Message-ID: <555BD66A.5020704@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/19/2015 09:53 PM, Arnd Bergmann wrote: > The recently added iommu code in the nouveau driver fails to build > when the IOMMU support is disabled: > > drivers/gpu/drm/nouveau/nouveau_platform.c: In function 'nouveau_platform_probe_iommu': > drivers/gpu/drm/nouveau/nouveau_platform.c:113:41: error: 'const struct iommu_ops' has no mem > > To avoid the build error, this now adds an explicit dependency on the > IOMMU implementation. I have a local patch to nouveau_platform.c that only calls the IOMMU functions if CONFIG_IOMMU is set. Wouldn't this be more suitable as IOMMU support is only used by Tegra and thus not beneficial for desktop GPUs? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH] drm/nouveau/platform: add IOMMU dependency Date: Wed, 20 May 2015 09:33:46 +0900 Message-ID: <555BD66A.5020704@nvidia.com> References: <2918377.0irYYn09PU@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 243956E38F for ; Tue, 19 May 2015 17:33:59 -0700 (PDT) In-Reply-To: <2918377.0irYYn09PU@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann , David Airlie Cc: linux-arm-kernel@lists.infradead.org, Thierry Reding , Ben Skeggs , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMDUvMTkvMjAxNSAwOTo1MyBQTSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiBUaGUgcmVjZW50 bHkgYWRkZWQgaW9tbXUgY29kZSBpbiB0aGUgbm91dmVhdSBkcml2ZXIgZmFpbHMgdG8gYnVpbGQK PiB3aGVuIHRoZSBJT01NVSBzdXBwb3J0IGlzIGRpc2FibGVkOgo+Cj4gZHJpdmVycy9ncHUvZHJt L25vdXZlYXUvbm91dmVhdV9wbGF0Zm9ybS5jOiBJbiBmdW5jdGlvbiAnbm91dmVhdV9wbGF0Zm9y bV9wcm9iZV9pb21tdSc6Cj4gZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9wbGF0Zm9y bS5jOjExMzo0MTogZXJyb3I6ICdjb25zdCBzdHJ1Y3QgaW9tbXVfb3BzJyBoYXMgbm8gbWVtCj4K PiBUbyBhdm9pZCB0aGUgYnVpbGQgZXJyb3IsIHRoaXMgbm93IGFkZHMgYW4gZXhwbGljaXQgZGVw ZW5kZW5jeSBvbiB0aGUKPiBJT01NVSBpbXBsZW1lbnRhdGlvbi4KCkkgaGF2ZSBhIGxvY2FsIHBh dGNoIHRvIG5vdXZlYXVfcGxhdGZvcm0uYyB0aGF0IG9ubHkgY2FsbHMgdGhlIElPTU1VIApmdW5j dGlvbnMgaWYgQ09ORklHX0lPTU1VIGlzIHNldC4gV291bGRuJ3QgdGhpcyBiZSBtb3JlIHN1aXRh YmxlIGFzIApJT01NVSBzdXBwb3J0IGlzIG9ubHkgdXNlZCBieSBUZWdyYSBhbmQgdGh1cyBub3Qg YmVuZWZpY2lhbCBmb3IgZGVza3RvcCAKR1BVcz8KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033AbbETAeC (ORCPT ); Tue, 19 May 2015 20:34:02 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:13350 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbbETAd7 (ORCPT ); Tue, 19 May 2015 20:33:59 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 19 May 2015 17:31:09 -0700 Message-ID: <555BD66A.5020704@nvidia.com> Date: Wed, 20 May 2015 09:33:46 +0900 From: Alexandre Courbot User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnd Bergmann , David Airlie CC: Ben Skeggs , Thierry Reding , , , Subject: Re: [PATCH] drm/nouveau/platform: add IOMMU dependency References: <2918377.0irYYn09PU@wuerfel> In-Reply-To: <2918377.0irYYn09PU@wuerfel> X-Originating-IP: [10.19.62.24] X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To HKMAIL103.nvidia.com (10.18.16.12) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2015 09:53 PM, Arnd Bergmann wrote: > The recently added iommu code in the nouveau driver fails to build > when the IOMMU support is disabled: > > drivers/gpu/drm/nouveau/nouveau_platform.c: In function 'nouveau_platform_probe_iommu': > drivers/gpu/drm/nouveau/nouveau_platform.c:113:41: error: 'const struct iommu_ops' has no mem > > To avoid the build error, this now adds an explicit dependency on the > IOMMU implementation. I have a local patch to nouveau_platform.c that only calls the IOMMU functions if CONFIG_IOMMU is set. Wouldn't this be more suitable as IOMMU support is only used by Tegra and thus not beneficial for desktop GPUs?