From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751637AbbETBdX (ORCPT ); Tue, 19 May 2015 21:33:23 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:38149 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbbETBdW (ORCPT ); Tue, 19 May 2015 21:33:22 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79106d00000728c-06-555be45fc22e Content-transfer-encoding: 8BIT Message-id: <555BE45E.7010201@samsung.com> Date: Wed, 20 May 2015 10:33:18 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 To: =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= Cc: MyungJoo Ham , Roger Quadros , Felipe Balbi , kernel@pengutronix.de, Linus Walleij , Alexandre Courbot , linux-kernel Subject: Re: [PATCH v2] extcon: usb-gpio: use flags argument of devm_gpiod_get to set direction References: <1432037910-27614-1-git-send-email-u.kleine-koenig@pengutronix.de> In-reply-to: <1432037910-27614-1-git-send-email-u.kleine-koenig@pengutronix.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsWyRsSkRDf+SXSowdY/8hYH79dbnHv1iMVi 1dSdLBZT/ixnsri8aw6bxe3GFWwWPY+0LG5PnMzowOGxc9Zddo871/awefT/NfDo27KK0eP4 je1MHp83yQWwRXHZpKTmZJalFunbJXBlzP+ymqmgiadiztzrjA2MDzi7GDk5JARMJBZ1XmeH sMUkLtxbzwZiCwksZZR4cSSwi5EDrOZvK08XIxdQeBGjxInXe1hAangFBCV+TL7HAlLDLCAv ceRSNkiYWUBdYtK8RcwQ9Q8YJSbdm84IUa8lMe/qN7D5LAKqEk9aJzGB2GxA8f0vboDFRQXC JFZOvwI2X0TAU2J36y02kEHMAs1MEid+/wBrEBZIlOjfP5sZ4lA/iYknNoM9wCngL3Ht+kdW kAYJgXvsEm9n3GSB2CYg8W3yIRaIb2QlNh1ghnhYUuLgihssExjFZiH5ZxbCP7OQ/LOAkXkV o2hqQXJBcVJ6kaFecWJucWleul5yfu4mRmAEnv73rHcH4+0D1ocYBTgYlXh4Cw5EhwqxJpYV V+YeYjQFOmIis5Rocj4wzvNK4g2NzYwsTE1MjY3MLc2UxHkVpX4GCwmkJ5akZqemFqQWxReV 5qQWH2Jk4uCUamAs2XBo8RZpi3XnjWrP/jmhek995tMHKluyFqzZvuHcSyHBk/aVStol32Vv XG8VVpk2I3aOZ7BcJN/WzYwG22ZfspmT4p54KfLSwxpv9tQJSgdzb4q/ipGIt/77P6pT94ay /Lx/R/83O3479rezWXjHlisy4l1+62rEgj9uV1T3XbOd421KzlltJZbijERDLeai4kQAsQMe drsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jAd34J9GhBitWSlgcvF9vce7VIxaL VVN3slhM+bOcyeLyrjlsFrcbV7BZ9DzSsrg9cTKjA4fHzll32T3uXNvD5tH/18Cjb8sqRo/j N7YzeXzeJBfAFtXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+Ti E6DrlpkDdI6SQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCGMWP+l9VMBU08 FXPmXmdsYHzA2cXIwSEhYCLxt5Wni5ETyBSTuHBvPVsXIxeHkMAiRokTr/ewgCR4BQQlfky+ xwJSzywgL3HkUjZImFlAXWLSvEXMEPUPGCUm3ZvOCFGvJTHv6jc2EJtFQFXiSeskJhCbDSi+ /8UNsLioQJjEyulXwOaLCHhK7G69BbaYWaCZSeLE7x9gDcICiRL9+2czg9hCAn4SE09sZgex OQX8Ja5d/8g6gVFgFpL7ZiHcNwvJfQsYmVcxiqYWJBcUJ6XnGuoVJ+YWl+al6yXn525iBEf4 M6kdjCsbLA4xCnAwKvHwFhyIDhViTSwrrsw9xCjBwawkwjtrJlCINyWxsiq1KD++qDQntfgQ oynQdxOZpUST84HJJ68k3tDYxMzI0sjc0MLI2FxJnPdkvk+okEB6YklqdmpqQWoRTB8TB6dU AyPb7Hvnynbz6edofn2ov/7i5+5KtVuT7kmce3/w9lNpXWvGqQ9+fl0oteWViOPKeNtZRgx6 y/d3zC6Wswy9qdf6fLMdoyPDSenw9T6tBqbr+bwL/gg9rb/JY5bFd17PQmvjbR+GmG/Lgrvs N21fauHeq5LaxCsxRdPX+cWlEy82rjk5Yd/W6gVKLMUZiYZazEXFiQBpG4TGBgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, You must send the extcon patch to the linux-kernel@vger.kernel.org. On 05/19/2015 09:18 PM, Uwe Kleine-König wrote: > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) > which appeared in v3.17-rc1, the gpiod_get* functions take an additional > parameter that allows to specify direction and initial value for output. > > Without this patch there is no call to gpiod_direction_input but the > gpio is used for irq reporting and for that the line should be in input > mode. > > Signed-off-by: Uwe Kleine-König > --- > > Notes: > Changes since (implicit) v1, sent with > Message-Id: 1432020518-19389-1-git-send-email-u.kleine-koenig@pengutronix.de: > > - drop Fixes: > - make it actually compile > > drivers/extcon/extcon-usb-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index e45d1f13f445..df7f3f32e325 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -113,7 +113,7 @@ static int usb_extcon_probe(struct platform_device *pdev) > return -ENOMEM; > > info->dev = dev; > - info->id_gpiod = devm_gpiod_get(&pdev->dev, "id"); > + info->id_gpiod = devm_gpiod_get(&pdev->dev, "id", GPIOD_IN); > if (IS_ERR(info->id_gpiod)) { > dev_err(dev, "failed to get ID GPIO\n"); > return PTR_ERR(info->id_gpiod); > Applied it. Thanks, Chanwoo Choi