All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: Christopher Larson <clarson@kergoth.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] buildstats-summary: add eventmask
Date: Wed, 20 May 2015 10:17:52 +0800	[thread overview]
Message-ID: <555BEED0.2010909@windriver.com> (raw)
In-Reply-To: <CABcZAN=Ky_TKqC8y3ecYh7Mf_SkQYJ0UUvDXMHnQCKZBpW+1KA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On 05/19/2015 09:40 PM, Christopher Larson wrote:
>
> On Tue, May 19, 2015 at 3:47 AM, Richard Purdie 
> <richard.purdie@linuxfoundation.org 
> <mailto:richard.purdie@linuxfoundation.org>> wrote:
>
>     On Tue, 2015-05-19 at 16:29 +0800, Chen Qi wrote:
>     > Add eventmask for buildstats_summary handler.
>
>     Why?
>
>     This says what you've done but not why we need this...
>
>     Cheers,
>
>     Richard
>
>
> Also, this adds the eventmask, but doesn’t remove the then-redundant 
> isinstance() on the event object.

Hi Richard and Christopher,

Thanks for you advice.
I'll send out V2.

Regards,
Chen Qi

> -- 
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics


[-- Attachment #2: Type: text/html, Size: 2303 bytes --]

      reply	other threads:[~2015-05-20  2:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19  8:29 [PATCH 0/1] buildstats-summary: add eventmask Chen Qi
2015-05-19  8:29 ` [PATCH 1/1] " Chen Qi
2015-05-19 10:47   ` Richard Purdie
2015-05-19 13:40     ` Christopher Larson
2015-05-20  2:17       ` ChenQi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555BEED0.2010909@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.