From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuvKs-0004kM-HC for qemu-devel@nongnu.org; Wed, 20 May 2015 00:10:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuvKp-00062I-8C for qemu-devel@nongnu.org; Wed, 20 May 2015 00:10:26 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:29599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuvKo-000605-EW for qemu-devel@nongnu.org; Wed, 20 May 2015 00:10:22 -0400 Message-ID: <555C090F.8020900@huawei.com> Date: Wed, 20 May 2015 12:09:51 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1430990964-10528-1-git-send-email-zhaoshenglong@huawei.com> <1430990964-10528-6-git-send-email-zhaoshenglong@huawei.com> <20150515144504.26a874cc@nial.brq.redhat.com> <555963C9.7020204@huawei.com> <20150518123333-mutt-send-email-mst@redhat.com> <20150519140913.275a58bc@nial.brq.redhat.com> In-Reply-To: <20150519140913.275a58bc@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On 2015/5/19 20:09, Igor Mammedov wrote: >> > Also, enum values must all be formatted like this: >> > UPPER_CASE > may be better not, for consistency with the rest of enums in this header. > Will add another patch to fix the enums of this header firstly. -- Shannon