All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: dev@dpdk.org
Subject: Re: [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups
Date: Wed, 20 May 2015 08:04:09 +0200	[thread overview]
Message-ID: <555C23D9.2020002@netinsight.net> (raw)
In-Reply-To: <20150507151754.1620c4cb@miho>

Ping?

// Simon

On 2015-05-07 15:17, Simon Kagstrom wrote:
> This is needed to add / remove interfaces in multicast groups via the
> ip tool.
> 
> The callback does nothing - the same as the kernel tun.c.
> 
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> ---
> Marked RFC since I'm by no means an expert on this. We noticed this
> when playing with KNI and IGMP handling.
> 
>  lib/librte_eal/linuxapp/kni/kni_net.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c
> b/lib/librte_eal/linuxapp/kni/kni_net.c index dd95db5..cf93c4b 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -495,6 +495,11 @@ kni_net_ioctl(struct net_device *dev, struct ifreq
> *rq, int cmd) return 0;
>  }
>  
> +static void
> +kni_net_set_rx_mode(struct net_device *dev)
> +{
> +}
> +
>  static int
>  kni_net_change_mtu(struct net_device *dev, int new_mtu)
>  {
> @@ -645,6 +650,7 @@ static const struct net_device_ops
> kni_net_netdev_ops = { .ndo_start_xmit = kni_net_tx,
>  	.ndo_change_mtu = kni_net_change_mtu,
>  	.ndo_do_ioctl = kni_net_ioctl,
> +	.ndo_set_rx_mode = kni_net_set_rx_mode,
>  	.ndo_get_stats = kni_net_stats,
>  	.ndo_tx_timeout = kni_net_tx_timeout,
>  	.ndo_set_mac_address = kni_net_set_mac,
> 

  reply	other threads:[~2015-05-20  6:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 13:17 [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups Simon Kagstrom
2015-05-20  6:04 ` Simon Kågström [this message]
2015-05-28  9:11 ` Simon Kågström
2015-05-28 14:56 ` Stephen Hemminger
2015-06-02  3:44 ` Zhang, Helin
2015-06-02  5:43   ` Simon Kågström
2015-06-02  5:48     ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555C23D9.2020002@netinsight.net \
    --to=simon.kagstrom@netinsight.net \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.