Re: [PATCH 2/2] livepatch: introduce patch/func-walking helpers

[Jiri Slaby <jslaby@suse.cz>]

On 05/20/2015, 03:51 AM, Minfei Huang wrote:
> Sure. Sorry for confuse you with my comment.

Oh, I see now, but:

> list_for_each_entry(patch, &klp_patches, list) {
> 	for (obj = patch->objs; obj->funcs; obj++) {
> ----------------------------------
> We get the fisrt object from the patch, then we break the loop. The code is more clearly to
> use "if", instead of the loop.
> ----------------------------------
> 		if (!klp_is_module(obj) || strcmp(obj->name, mod->name))
> 			continue;

See 'continue' here. This *is* a loop and we do not fetch the first
object. We look for the one with the same name.

> 		if (action == MODULE_STATE_COMING) {
> 			obj->mod = mod;
> 			klp_module_notify_coming(patch, obj);
> 		} else /* MODULE_STATE_GOING */
> 			klp_module_notify_going(patch, obj);
> 
> 		break;
> ----------------------------------
> Here we break the loop.

Only if we found the one.

> ----------------------------------
> 	}
> }

thanks,
-- 
js
suse labs