From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: David Miller <davem@davemloft.net>, linville@tuxdriver.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] vxlan: correct typo in call to unregister_netdevice_queue
Date: Wed, 20 May 2015 10:12:28 +0200 [thread overview]
Message-ID: <555C41EC.6040100@6wind.com> (raw)
In-Reply-To: <20150518.165941.65628962518379011.davem@davemloft.net>
Le 18/05/2015 22:59, David Miller a écrit :
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Mon, 18 May 2015 13:51:24 -0400
>
>> By inspection, this appears to be a typo. The gating comparison
>> involves vxlan->dev rather than dev. In fact, dev is the iterator in
>> the preceding loop above but it is actually constant in the 2nd loop.
>>
>> Use of dev seems to be a bad cut-n-paste from the prior call to
>> unregister_netdevice_queue. Change dev to vxlan->dev, since that is
>> what is actually being checked.
>>
>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Indeed, your fix looks correct to me.
>
> Applied, thanks John.
>
I was off the last couple of days. But I agree with that patch.
FWIW:
Fixes: f01ec1c017de ("vxlan: add x-netns support")
prev parent reply other threads:[~2015-05-20 8:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:51 [PATCH] vxlan: correct typo in call to unregister_netdevice_queue John W. Linville
2015-05-18 20:59 ` David Miller
2015-05-20 8:12 ` Nicolas Dichtel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C41EC.6040100@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.