From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Amir Vadai <amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Tal Alon <talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next 02/10] IB/core: Add flags parameter for ib_create_cq
Date: Wed, 20 May 2015 11:54:03 +0300 [thread overview]
Message-ID: <555C4BAB.6090602@dev.mellanox.co.il> (raw)
In-Reply-To: <20150519184711.GK18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On 5/19/2015 9:47 PM, Jason Gunthorpe wrote:
> On Sun, May 17, 2015 at 04:36:18PM +0300, Or Gerlitz wrote:
>> From: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> We add a flags parameter for ib_create_cq in order
>> to specify creation flags for the CQ.
>
> Why?
>
> At this point you should keep flowing ib_cq_init_attr up to callers of
> ib_create_cq , so we don't have to do this again.
>
> It makes sense to keep that as a distinct patch..
I completely agree with Jason. Let's move away from
non-easily-extendale APIs.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-20 8:54 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 13:36 [PATCH for-next 00/10] Add completion timestamping support Or Gerlitz
[not found] ` <1431869786-6308-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-17 13:36 ` [PATCH for-next 01/10] IB/core: Change provider's API of create_cq to be extendible Or Gerlitz
[not found] ` <1431869786-6308-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 18:45 ` Jason Gunthorpe
[not found] ` <20150519184535.GJ18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 15:14 ` Yann Droneaud
2015-05-20 16:41 ` Matan Barak
[not found] ` <CAAKD3BAXBPgkFp=bmeDNoj6QbAXoHMGt_nv+LHCE09g5=nyPGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-20 19:01 ` Jason Gunthorpe
2015-05-17 13:36 ` [PATCH for-next 02/10] IB/core: Add flags parameter for ib_create_cq Or Gerlitz
[not found] ` <1431869786-6308-3-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 18:47 ` Jason Gunthorpe
[not found] ` <20150519184711.GK18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 8:54 ` Sagi Grimberg [this message]
[not found] ` <555C4BAB.6090602-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-05-20 16:44 ` Matan Barak
2015-05-20 15:24 ` Yann Droneaud
[not found] ` <1432135457.5304.33.camel-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2015-05-20 16:46 ` Matan Barak
2015-05-17 13:36 ` [PATCH for-next 03/10] IB/core: Extend ib_uverbs_create_cq Or Gerlitz
2015-05-17 13:36 ` [PATCH for-next 04/10] IB/core: Add timestamp_mask and hca_core_clock to query_device Or Gerlitz
2015-05-17 13:36 ` [PATCH for-next 05/10] IB/core: Pass hardware specific data in query_device Or Gerlitz
2015-05-17 13:36 ` [PATCH for-next 06/10] IB/mlx4: Add mmap call to map the hardware clock Or Gerlitz
2015-05-17 13:36 ` [PATCH for-next 07/10] IB/mlx4: Support extended create_cq and query_device uverbs Or Gerlitz
2015-05-17 13:36 ` [PATCH for-next 08/10] IB/mlx4: Add support for timestamp in cq creation Or Gerlitz
[not found] ` <1431869786-6308-9-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 18:55 ` Jason Gunthorpe
[not found] ` <20150519185527.GL18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 8:56 ` Sagi Grimberg
[not found] ` <555C4C45.7010300-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-05-20 14:43 ` Or Gerlitz
2015-05-20 17:27 ` Jason Gunthorpe
2015-05-17 13:36 ` [PATCH for-next 09/10] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device Or Gerlitz
[not found] ` <1431869786-6308-10-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-19 18:58 ` Jason Gunthorpe
[not found] ` <20150519185801.GM18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-19 19:00 ` Jason Gunthorpe
[not found] ` <20150519190031.GN18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-19 19:11 ` Or Gerlitz
[not found] ` <CAJ3xEMiO2y6G5YzzkGC1M=XB6yrtNJ7jj13pTUAee1TssiYwkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-19 19:15 ` Jason Gunthorpe
[not found] ` <20150519191553.GP18675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-19 19:30 ` Or Gerlitz
[not found] ` <CAJ3xEMjj31SpZmYXORCePVCQfMOWVKEhtNay-v59FcnCOQWm9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-20 0:29 ` Jason Gunthorpe
[not found] ` <20150520002915.GD16941-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-20 14:40 ` Or Gerlitz
2015-05-20 14:41 ` Or Gerlitz
[not found] ` <555C9D00.2090609-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-20 15:11 ` Yann Droneaud
[not found] ` <1432134677.5304.23.camel-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2015-05-20 17:37 ` Jason Gunthorpe
2015-05-20 17:53 ` Or Gerlitz
[not found] ` <CAJ3xEMjO2HqFePAwXnoCt0rCzRLfYbqdP+883v4LaMovj7Y-FA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-23 4:26 ` Or Gerlitz
[not found] ` <CAJ3xEMgppUPqOFm7L0+fR3z_N2ALZFb+GpSAGvyyNROZoFCUPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-26 8:10 ` Or Gerlitz
[not found] ` <CAJ3xEMinNsQrmQ7atAVkshefBDBQ1HRuGbOT_cJ4RxEj4dWUPA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-26 16:06 ` Jason Gunthorpe
[not found] ` <20150526160624.GA11800-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-26 18:33 ` Or Gerlitz
[not found] ` <CAJ3xEMj5qphSq5QQHKPsihuK6StmJ+NHiPbkY-ZVGmpViB1AXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-26 18:53 ` Jason Gunthorpe
[not found] ` <20150526185315.GF11800-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-26 20:39 ` Or Gerlitz
[not found] ` <CAJ3xEMh7JYN8sP5MYdVjH=tqPFURwvD7jVvV0=PBiEn1qEFi2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-26 22:07 ` Jason Gunthorpe
[not found] ` <20150526220724.GC4502-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-27 11:54 ` Or Gerlitz
[not found] ` <CAJ3xEMgdqBnn6hobRJFut6Nyu2pKt40rb46Z3dYx3MaohR2urA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-27 18:48 ` Jason Gunthorpe
[not found] ` <20150527184856.GA16059-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-27 21:33 ` Or Gerlitz
[not found] ` <CAJ3xEMh_g0zBza5HoVZTy9cTRbXqatzvBMAJcRjQhH7Zi=cHAg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-27 22:21 ` Jason Gunthorpe
[not found] ` <20150527222108.GA7855-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-28 7:04 ` Or Gerlitz
[not found] ` <5566BDE4.50709-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-05-28 14:13 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1505280908001.16142-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-05-28 16:24 ` Jason Gunthorpe
[not found] ` <20150528162416.GA6515-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-28 17:14 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1505281212330.1711-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-05-28 17:50 ` Jason Gunthorpe
[not found] ` <20150528175043.GA10966-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-28 18:30 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1505281325150.1794-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-05-28 19:50 ` Jason Gunthorpe
[not found] ` <20150528195034.GA11182-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-28 20:34 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1505281522020.2703-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-05-28 20:47 ` Jason Gunthorpe
[not found] ` <20150528204749.GA12780-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-29 7:59 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FE1F36-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-29 13:55 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1505290846480.8178-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-05-29 16:52 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FE2069-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-29 19:21 ` Steve Wise
2015-06-01 11:50 ` Christoph Lameter
2015-05-29 13:46 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1505290845040.8178-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-05-29 16:49 ` Doug Ledford
[not found] ` <1432918170.114391.104.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-29 16:59 ` Christoph Lameter
2015-05-29 17:09 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FE2126-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-29 17:14 ` Doug Ledford
[not found] ` <1432919688.114391.116.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-29 17:18 ` Hefty, Sean
2015-06-01 11:39 ` Christoph Lameter
[not found] ` <alpine.DEB.2.11.1506010635360.25165-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2015-06-01 14:54 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FE2688-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-06-04 0:58 ` Christoph Lameter
2015-05-29 16:59 ` Doug Ledford
[not found] ` <1432918767.114391.110.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-01 11:44 ` Christoph Lameter
2015-05-17 13:36 ` [PATCH for-next 10/10] IB/mlx4: Return hca core clock's offset in query_device vendor's data Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C4BAB.6090602@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=talal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.