From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326AbbETJAv (ORCPT ); Wed, 20 May 2015 05:00:51 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:43801 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbbETJAs (ORCPT ); Wed, 20 May 2015 05:00:48 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <555C4D3D.7040404@mev.co.uk> Date: Wed, 20 May 2015 10:00:45 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Sudip Mukherjee , Amaury Denoyelle CC: devel@driverdev.osuosl.org, Greg Kroah-Hartman , H Hartley Sweeten , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c References: <20150519054750.GD3820@sudip-PC> <1432058270-16752-1-git-send-email-amaury.denoyelle@gmail.com> <1432058270-16752-2-git-send-email-amaury.denoyelle@gmail.com> <20150520050204.GA4764@sudip-PC> <20150520072418.hqGGkijxvtc=%amaury.denoyelle@gmail> <20150520082223.GB2997@sudip-PC> In-Reply-To: <20150520082223.GB2997@sudip-PC> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/15 09:22, Sudip Mukherjee wrote: > On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote: >> Sudip Mukherjee wrote: >> >>> On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote: >>> >>>> @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct comedi_device *dev, >>>> return devpriv->ai_fifo_segment_length; >>>> } >>>> >>>> -/* adjusts the size of hardware fifo (which determines block size for dma xfers) */ >>>> +/* >>>> + * adjusts the size of hardware fifo (which determines block size for dma xfers) >>>> + */ >>> I did not understand this one. You are not breaking the comment into >>> two lines, then why multiline style? >>> >>>> const struct pcidas64_board *thisboard = dev->board_ptr; >>>> @@ -1588,7 +1591,9 @@ static inline void warn_external_queue(struct comedi_device *dev) >>>> "Use internal AI channel queue (channels must be consecutive and use same range/aref)\n"); >>>> } >>>> >>>> -/* Their i2c requires a huge delay on setting clock or data high for some reason */ >>>> +/* >>>> + * their i2c requires a huge delay on setting clock or data high for some reason >>>> + */ >>> same here. >>> >> >> The single-line version of these comments are over 80 characters (just >> because of the "*/" characters), so I had to split them over several >> lines. > yes, i noticed. its almost 84 char. but after applying your patch also > it comes to 81. Really? I only see 80 characters. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-