From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Tiejun" <tiejun.chen@intel.com>
Subject: Re: [PATCH] xen/pci: correct comment of
	pci_device_detect()
Date: Wed, 20 May 2015 18:49:30 +0800
Message-ID: <555C66BA.9070901@intel.com>
References: <1432104797-19006-1-git-send-email-tiejun.chen@intel.com>
	<555C78D7020000780007C0EC@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <555C78D7020000780007C0EC@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 2015/5/20 18:06, Jan Beulich wrote:
>>>> On 20.05.15 at 08:53, <tiejun.chen@intel.com> wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -905,7 +905,7 @@ out:
>>   }
>>
>>   /*
>> - * detect pci device, return 0 if it exists, or return 0
>> + * detect pci device, return 1 if it exists, or return 0
>>    */
>>   int __init pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func)
>
> The comment is pretty pointless, and could go away altogether if
> the function's return type was switched to bool_t. Care to do such

Yeah, I also consider this change initially but I'm not sure if this is 
necessary. Now I think I'd like to follow this.

> an alternative patch (including replacing some of the callers using
> == 0 on the result to use ! instead)?
>

Sure.

Thanks
Tiejun