From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34421) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv1zI-00014A-84 for qemu-devel@nongnu.org; Wed, 20 May 2015 07:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yv1zE-0003tZ-8q for qemu-devel@nongnu.org; Wed, 20 May 2015 07:16:36 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:57655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yv1zD-0003rP-OY for qemu-devel@nongnu.org; Wed, 20 May 2015 07:16:32 -0400 Message-ID: <555C6C28.8020506@huawei.com> Date: Wed, 20 May 2015 19:12:40 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1431595182-7552-21-git-send-email-zhaoshenglong@huawei.com> <1432098058-11124-1-git-send-email-zhaoshenglong@huawei.com> <20150520130102.6ef88266@nial.brq.redhat.com> In-Reply-To: <20150520130102.6ef88266@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v7 20/23] hw/acpi/aml-build: Add Unicode macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, alex.bennee@linaro.org, hanjun.guo@linaro.org, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org, shannon.zhao@linaro.org On 2015/5/20 19:01, Igor Mammedov wrote: > On Wed, 20 May 2015 13:00:58 +0800 > Shannon Zhao wrote: > > when you submit a new version of patch vXX supposed to go up, > otherwise how would reader know that it's not the same as before. > Hmm, sorry, I thought I added "RESEND" prefix to distinguish this from the previous one. Isn't this right? >> From: Shannon Zhao >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao > Reviewed-by: Igor Mammedov > >> --- >> hw/acpi/aml-build.c | 17 +++++++++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 18 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 9a80b80..aa34d0a 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1121,6 +1121,23 @@ Aml *aml_touuid(const char *uuid) >> return var; >> } >> >> +/* >> + * ACPI 2.0b: 16.2.3.6.4.3 Unicode Macro (Convert Ascii String To Unicode) >> + */ >> +Aml *aml_unicode(const char *str) >> +{ >> + int i = 0; >> + Aml *var = aml_bundle(0x11 /* BufferOp */, AML_BUFFER); >> + >> + do { >> + build_append_byte(var->buf, str[i]); >> + build_append_byte(var->buf, 0); >> + i++; >> + } while (i <= strlen(str)); >> + >> + return var; >> +} >> + >> void >> build_header(GArray *linker, GArray *table_data, >> AcpiTableHeader *h, const char *sig, int len, uint8_t rev) >> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h >> index b81c838..9773bfd 100644 >> --- a/include/hw/acpi/aml-build.h >> +++ b/include/hw/acpi/aml-build.h >> @@ -267,6 +267,7 @@ Aml *aml_field(const char *name, AmlAccessType type, AmlUpdateRule rule); >> Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name); >> Aml *aml_varpackage(uint32_t num_elements); >> Aml *aml_touuid(const char *uuid); >> +Aml *aml_unicode(const char *str); >> >> void >> build_header(GArray *linker, GArray *table_data, > > > . > -- Shannon