From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Tim Deegan <tim@xen.org>
Cc: Kevin Tian <kevin.tian@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Eddie Dong <eddie.dong@intel.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v7 1/2] xen/pvh: use a custom IO bitmap for PVH hardware domains
Date: Wed, 20 May 2015 14:03:09 +0200 [thread overview]
Message-ID: <555C77FD.5020708@citrix.com> (raw)
In-Reply-To: <555C9044020000780007C1A2@mail.emea.novell.com>
El 20/05/15 a les 13.46, Jan Beulich ha escrit:
>>>> On 20.05.15 at 12:11, <roger.pau@citrix.com> wrote:
>> --- a/xen/common/domain.c
>> +++ b/xen/common/domain.c
>> @@ -42,6 +42,7 @@
>> #include <xsm/xsm.h>
>> #include <xen/trace.h>
>> #include <xen/tmem.h>
>> +#include <asm/setup.h>
>
> This caused the ARM build to fail. Instead of once again reverting I
> applied the trivial fix eab0647587 without asking for permission by
> you ARM maintainers - I hope that's okay in a case like this.
I'm sorry but I'm not sure what's wrong with this chunk, and AFAICT you
seem to have applied it unmodified. The code added in
xen/common/domain.c is protected with #ifdef CONFIG_X86 and ARM has a
setup.h header.
> But Roger, considering how many issues recent patches of yours
> introduced - please apply a little more care.
Yes, and I'm really sorry for that.
Roger.
next prev parent reply other threads:[~2015-05-20 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 10:11 [PATCH v7 0/2] xen/pvh: use a custom IO bitmap for PVH hardware domains Roger Pau Monne
2015-05-20 10:11 ` [PATCH v7 1/2] " Roger Pau Monne
2015-05-20 11:46 ` Jan Beulich
2015-05-20 12:03 ` Roger Pau Monné [this message]
2015-05-20 12:07 ` Jan Beulich
2015-05-20 12:08 ` Roger Pau Monné
2015-05-20 12:05 ` Ian Campbell
2015-05-20 12:09 ` Jan Beulich
2015-05-20 10:11 ` [PATCH v7 2/2] xen/pvh: trap access to sensitive IO ports Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555C77FD.5020708@citrix.com \
--to=roger.pau@citrix.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.