From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v7 1/2] xen/pvh: use a custom IO bitmap for
 PVH hardware domains
Date: Wed, 20 May 2015 14:08:51 +0200
Message-ID: <555C7953.6070805@citrix.com>
References: <1432116691-50098-1-git-send-email-roger.pau@citrix.com>
	<1432116691-50098-2-git-send-email-roger.pau@citrix.com>
	<555C9044020000780007C1A2@mail.emea.novell.com>
	<555C77FD.5020708@citrix.com>
	<555C951F020000780007C1F2@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <roger.pau@citrix.com>) id 1Yv2o4-0007ce-11
	for xen-devel@lists.xenproject.org; Wed, 20 May 2015 12:09:04 +0000
In-Reply-To: <555C951F020000780007C1F2@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Jun Nakajima <jun.nakajima@intel.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Eddie Dong <eddie.dong@intel.com>, Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@eu.citrix.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, SuraveeSuthikulpanit <suravee.suthikulpanit@amd.com>, xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

El 20/05/15 a les 14.07, Jan Beulich ha escrit:
>>>> On 20.05.15 at 14:03, <roger.pau@citrix.com> wrote:
>> El 20/05/15 a les 13.46, Jan Beulich ha escrit:
>>>>>> On 20.05.15 at 12:11, <roger.pau@citrix.com> wrote:
>>>> --- a/xen/common/domain.c
>>>> +++ b/xen/common/domain.c
>>>> @@ -42,6 +42,7 @@
>>>>  #include <xsm/xsm.h>
>>>>  #include <xen/trace.h>
>>>>  #include <xen/tmem.h>
>>>> +#include <asm/setup.h>
>>>
>>> This caused the ARM build to fail. Instead of once again reverting I
>>> applied the trivial fix eab0647587 without asking for permission by
>>> you ARM maintainers - I hope that's okay in a case like this.
>>
>> I'm sorry but I'm not sure what's wrong with this chunk, and AFAICT you
>> seem to have applied it unmodified. The code added in
>> xen/common/domain.c is protected with #ifdef CONFIG_X86 and ARM has a
>> setup.h header.
> 
> Right, but I suppose you then also looked at my fixup patch, which
> I think explains what was wrong?

Yes, sorry for that, I've understood that you modified the patch in
order to prevent ARM breakage, not that you pushed another on top.

Roger.