From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH] xen/public: Clarify xen_arch_domainconfig
	ABI statement
Date: Wed, 20 May 2015 10:12:29 -0400
Message-ID: <555C964D.7080502@one.verizon.com>
References: <1432127413-15478-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1432127413-15478-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 05/20/15 09:10, Andrew Cooper wrote:
> This structure is used by XEN_DOMCTL_createdomain, and is liable to be
> modified going forwards.  Explicitly state that it falls under the
> XEN_DOMCTL_INTERFACE_VERSION.
> 

Looks good to me.

Reviewed-by: Don Slutz <dslutz@verizon.com>

   -Don Slutz

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> CC: Tim Deegan <tim@xen.org>
> CC: Julien Grall <julien.grall@citrix.com>
> CC: Don Slutz <dslutz@verizon.com>
> ---
>  xen/include/public/arch-arm.h     |    4 ++++
>  xen/include/public/arch-x86/xen.h |    4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index c029e0f..6e38638 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -309,6 +309,10 @@ struct arch_shared_info {
>  typedef struct arch_shared_info arch_shared_info_t;
>  typedef uint64_t xen_callback_t;
>  
> +/*
> + * struct xen_arch_domainconfig's ABI is covered by the
> + * XEN_DOMCTL_INTERFACE_VERSION.
> + */
>  #define XEN_DOMCTL_CONFIG_GIC_DEFAULT   0
>  #define XEN_DOMCTL_CONFIG_GIC_V2        1
>  #define XEN_DOMCTL_CONFIG_GIC_V3        2
> diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
> index cea3fe7..b4ba233 100644
> --- a/xen/include/public/arch-x86/xen.h
> +++ b/xen/include/public/arch-x86/xen.h
> @@ -262,6 +262,10 @@ struct arch_shared_info {
>  };
>  typedef struct arch_shared_info arch_shared_info_t;
>  
> +/*
> + * struct xen_arch_domainconfig's ABI is covered by the
> + * XEN_DOMCTL_INTERFACE_VERSION.
> + */
>  struct xen_arch_domainconfig {
>      char dummy;
>  };
>