From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 9DDE8E005B9; Wed, 20 May 2015 07:50:55 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NORMAL_HTTP_TO_IP, RCVD_IN_DNSWL_LOW,WEIRD_PORT autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.220.52 listed in list.dnswl.org] * 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP * 0.0 NORMAL_HTTP_TO_IP URI: URI host has a public dotted-decimal IPv4 * address * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 43688E0027F for ; Wed, 20 May 2015 07:50:53 -0700 (PDT) Received: by padbw4 with SMTP id bw4so69690641pad.0 for ; Wed, 20 May 2015 07:50:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=i33htHfeXfrg7IVPGx+ZbfJ2HcaVTPjpT9qWbriDnTg=; b=U4D2x0hOrVXqxWhPg7CWYrZUlN5HDagwo0mZjqipLMO0gtVbQKAf2cTupQZL3DKDN9 gw9kQXPIaETCRUQeOGJ93Mdq394sYPks1aSsC+t4OT/0DId0uygdaqvfKusoT0xlimOV OzHwJjlgIZCMAq8tD1hVHehye64jrEZhocGF8I1UxMLxO7xLsjfKAQHPsTZDqwuu06Bt 5wxtiT+ZHUdQ+OGtINMyktZlR+Pu0ofK5MMovNNOnMzs/iZc6ey9iGJWeDpzy0yIOvda aS/tzHuzdDWHDk5Jyg6AjRMrZWftY3nisNQ70Q98O9Emqzo4sOZA4fPyO9GemAcz99gN FdBA== X-Gm-Message-State: ALoCoQl387yIsrI4TpwDz5JDI4NyUhVSuJR9pSyPpYV0DEMomQfCHnhKTPjNEh7STBJubfylV30i X-Received: by 10.70.37.167 with SMTP id z7mr65078054pdj.55.1432133453577; Wed, 20 May 2015 07:50:53 -0700 (PDT) Received: from [192.168.2.36] ([83.217.123.106]) by mx.google.com with ESMTPSA id by13sm16444382pdb.37.2015.05.20.07.50.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 May 2015 07:50:52 -0700 (PDT) Message-ID: <555C9F49.1020501@intel.com> Date: Wed, 20 May 2015 15:50:49 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Damian, Alexandru" References: <5554C229.4090101@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] michaelw/fix-toaster-unittests X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 14:50:55 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, OK, Pushed with those changes to the branch with the same name. Thanks, Michael On 15/05/15 14:58, Damian, Alexandru wrote: > Hi, > > Good work ! I like the approach to change hardcoded values with > environment variables. > > I would suggest that the variables have relevant names, e.g. prefixed > with "TTS_" for Toaster Testing System. Also, we need big fat warnings > if the variables are not set - this will help other people run the tests. > > I would prefer to have the patch split into changes for the tests > themselves, and changes to the toaster to fix failing tests. > > Cheers, > Alex > > On Thu, May 14, 2015 at 4:41 PM, Michael Wood > > wrote: > > > Special attention for review: > > diff --git > a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > index 1bd5143..f0fe28e 100644 > --- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > +++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py > @@ -117,7 +117,7 @@ class > LocalhostBEController(BuildEnvironmentController): > f.seek(0, 2) # jump to the end > toaster_ui_log_filelength = f.tell() > > - cmd = "bash -c \"source %s/oe-init-build-env %s 2>&1 > >toaster_server.log && bitbake --read conf/toaster-pre.conf > --postread conf/toaster.conf --server-only -t xmlrpc -B 0.0.0.0:0 > 2>&1 >toaster_server.log && DATABASE_URL=%s > BBSERVER=0.0.0.0:-1 daemon -d -i -D %s -o toaster_ui.log -- %s > --observe-only -u toasterui &\"" % (self.pokydirname, > self.be.builddir, > + cmd = "bash -c \"source %s/oe-init-build-env %s 2>&1 > >toaster_server.log && bitbake --read %s/conf/toaster-pre.conf > --postread %s/conf/toaster.conf --server-only -t xmlrpc -B > 0.0.0.0:0 2>&1 >toaster_server.log && > DATABASE_URL=%s BBSERVER=0.0.0.0:-1 daemon -d -i -D %s -o > toaster_ui.log -- %s --observe-only -u toasterui &\"" % > (self.pokydirname, self.be.builddir, self.be.builddir, > self.be.builddir, > > > commit 0d9e2362821ecf42f690afc0a247fd228cbbd853 > Author: Michael Wood > > Date: Thu May 14 11:20:46 2015 +0100 > > bitbake: toaster: Fix all the toaster unit test cases > > This fixes all the test cases that were broken and removes > some of the > hard coded values that hindered the tests being run elsewhere. > > Signed-off-by: Michael Wood > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >