From: Adrian Hunter <adrian.hunter@intel.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 2/4] perf tools: Fix dso__data_read_offset() file opening
Date: Wed, 20 May 2015 18:35:46 +0300 [thread overview]
Message-ID: <555CA9D2.7000805@intel.com> (raw)
In-Reply-To: <20150520151144.GE29162@danjae.kornet>
On 20/05/2015 6:11 p.m., Namhyung Kim wrote:
> On Wed, May 20, 2015 at 11:12:10AM +0300, Adrian Hunter wrote:
>> On 20/05/15 09:34, Namhyung Kim wrote:
>>> {
>>> enum dso_binary_type binary_type_data[] = {
>>> DSO_BINARY_TYPE__BUILD_ID_CACHE,
>>> @@ -457,14 +449,6 @@ int dso__data_fd(struct dso *dso, struct machine *machine)
>>> };
>>> int i = 0;
>>>
>>> - if (dso->data.status == DSO_DATA_STATUS_ERROR)
>>> - return -1;
>>
>> Please retain this check. It is needed to prevent repeatedly
>> trying to open files that aren't there.
>
> I just move it out of the function, so it'll be checked before
> entering this function without lock.
data_file_size() isn't doing that though. It just calls try_to_open_dso()
next prev parent reply other threads:[~2015-05-20 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 6:34 [PATCH 1/4] Revert "perf tools: Fix data_read_offset() file opening" Namhyung Kim
2015-05-20 6:34 ` [PATCH 2/4] perf tools: Fix dso__data_read_offset() file opening Namhyung Kim
2015-05-20 8:12 ` Adrian Hunter
2015-05-20 15:11 ` Namhyung Kim
2015-05-20 15:35 ` Adrian Hunter [this message]
2015-05-20 6:34 ` [PATCH 3/4] perf tools: Get rid of dso__data_fd() from dso__data_size() Namhyung Kim
2015-05-20 6:34 ` [PATCH 4/4] perf tools: Add dso__data_get/put_fd() Namhyung Kim
2015-05-20 8:33 ` Adrian Hunter
2015-05-20 15:34 ` Namhyung Kim
2015-05-20 15:55 ` Adrian Hunter
2015-05-20 13:28 ` [PATCH 1/4] Revert "perf tools: Fix data_read_offset() file opening" Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555CA9D2.7000805@intel.com \
--to=adrian.hunter@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.