From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, jdenemar@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of SETUP status
Date: Wed, 20 May 2015 12:03:59 -0400 [thread overview]
Message-ID: <555CB06F.3090804@redhat.com> (raw)
In-Reply-To: <555CAF31.9030507@redhat.com>
On 05/20/2015 11:58 AM, Eric Blake wrote:
> On 05/20/2015 09:35 AM, Juan Quintela wrote:
>> We assign the MIGRATION_STATUS_SETUP status in two places. Just
>> in sucession. Just remove the second one.
>
> s/sucession/succession/
>
Also s/assignement/assignment/ in the subject.
> Where's the second place? Not in migrate_fd_connect...
>
> okay, migrate_init() does the same thing, and I guess you're
> arguing that it was always called either just before or just after
> migrate_fd_connect can be called. But mentioning it in the commit
> message would help.
>
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com> ---
>> migration/migration.c | 3 --- 1 file changed, 3 deletions(-)
>>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
next prev parent reply other threads:[~2015-05-20 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:35 [Qemu-devel] [PATCH v4 0/3] Migration Events Juan Quintela
2015-05-20 15:35 ` [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of SETUP status Juan Quintela
2015-05-20 15:58 ` Eric Blake
2015-05-20 16:03 ` John Snow [this message]
2015-06-03 9:14 ` Juan Quintela
2015-05-20 15:35 ` [Qemu-devel] [PATCH 2/3] migration: create migration event Juan Quintela
2015-05-20 16:02 ` Eric Blake
2015-05-21 9:49 ` Juan Quintela
2015-06-17 0:20 ` Juan Quintela
2015-05-29 11:45 ` Jiri Denemark
2015-06-17 0:12 ` Juan Quintela
2015-05-20 15:35 ` [Qemu-devel] [PATCH 3/3] migration: Add migration events on target side Juan Quintela
2015-05-20 16:10 ` Eric Blake
2015-05-21 9:57 ` Juan Quintela
2015-06-02 12:44 ` [Qemu-devel] [PATCH v4 0/3] Migration Events Jiri Denemark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555CB06F.3090804@redhat.com \
--to=jsnow@redhat.com \
--cc=amit.shah@redhat.com \
--cc=eblake@redhat.com \
--cc=jdenemar@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.