From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 66B55E0095D; Wed, 20 May 2015 09:40:18 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 313D8E004F6 for ; Wed, 20 May 2015 09:40:16 -0700 (PDT) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id 4D4EAF811EC; Wed, 20 May 2015 10:40:16 -0600 (MDT) Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 878DCF811E6; Wed, 20 May 2015 10:40:15 -0600 (MDT) Message-ID: <555CB8FC.4040908@mlbassoc.com> Date: Wed, 20 May 2015 10:40:28 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Otavio Salvador , Fabio Estevam , Nikolay Dimitrov , Eric Nelson References: <1432137253-5312-1-git-send-email-gary@mlbassoc.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [PATCH] kernel 3.14.28/gpiolib: Return GPIO logical value, not true value X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 16:40:18 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2015-05-20 10:34, Otavio Salvador wrote: > On Wed, May 20, 2015 at 12:54 PM, Gary Thomas wrote: >> Previous versions of the kernel returned the logical value of >> GPIO signals (i.e. 0 or 1). This patch restores this behavior. >> >> Signed-off-by: Gary Thomas > > I am not sure this is a correct fix. I tried to find out the commit > which changed the behaviour without success. > > Fabio, is it possible for you to check how mainline is behaving? and > more important does it need any fix? > If by mainline you mean 4.1+, the code is very different and looks much more like the 3.10 version than the FSL 3.14. My change simply matches the behaviour (and indeed uses the same construct) as the 3.10 kernel. Also, as long as I can recall, reading a GPIO pin has returned 0/1, except for a small period during 2.6 where it was broken and quickly repaired. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------