From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id E59E8E0095D; Wed, 20 May 2015 10:34:09 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.chez-thomas.org (mail.mlbassoc.com [65.100.170.105]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id BFD98E004F6 for ; Wed, 20 May 2015 10:34:03 -0700 (PDT) Received: by mail.chez-thomas.org (Postfix, from userid 1998) id 7B5DCF811ED; Wed, 20 May 2015 11:34:03 -0600 (MDT) Received: from [192.168.1.114] (zeus [192.168.1.114]) by mail.chez-thomas.org (Postfix) with ESMTP id 8D4B7F811E6; Wed, 20 May 2015 11:34:02 -0600 (MDT) Message-ID: <555CC597.6070303@mlbassoc.com> Date: Wed, 20 May 2015 11:34:15 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Otavio Salvador References: <1432137253-5312-1-git-send-email-gary@mlbassoc.com> <20150520184919.3e6b8d9b@e6520eb.localdomain> <555CBBAB.9070906@mlbassoc.com> <20150520185718.38580cf6@e6520eb.localdomain> <555CC0E8.6020502@mlbassoc.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [PATCH] kernel 3.14.28/gpiolib: Return GPIO logical value, not true value X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 17:34:10 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 2015-05-20 11:26, Otavio Salvador wrote: > On Wed, May 20, 2015 at 2:14 PM, Gary Thomas wrote: >> On 2015-05-20 11:02, Fabio Estevam wrote: >>> >>> On Wed, May 20, 2015 at 1:57 PM, Eric Bénard wrote: >>> >>>> I think it should apply easily, as gpio-generic.c is very similar >>>> between 3.14.28 and mainline : >>>> >>>> 3.14.28 >>>> >>>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/gpio/gpio-generic.c?h=linux-3.14.y&id=v3.14.28#n142 >>>> >>>> commit 25b35da : >>>> >>>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/drivers/gpio/gpio-generic.c?id=25b35da7f4cce82271859f1b6eabd9f3bd41a2bb >>> >>> >>> Yes, agreed. It is a one-line patch, so we can easily use the mainline >>> fix. >>> >> >> I concur - my change was local to just the sysfs code, but >> this change is more correct (and already in mainline) > > Can you generate a proper patch for it? > Why not just cherry-pick from 25b35da? It then has all of the proper signed-off-by, etc. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------