From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v10 02/10] xen: Add support for VMware cpuid
 leaves
Date: Wed, 20 May 2015 14:14:57 -0400
Message-ID: <555CCF21.7020004@one.verizon.com>
References: <1431646469-23022-1-git-send-email-dslutz@verizon.com>	<1431646469-23022-3-git-send-email-dslutz@verizon.com>
	<555B96B8.4000005@citrix.com> <555C3FCF.6030304@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <555C3FCF.6030304@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 05/20/15 04:03, Julien Grall wrote:
> Hi,
> 
> On 19/05/2015 21:02, Andrew Cooper wrote:
>>> diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h
>>> index cea3fe7..5a5bad6 100644
>>> --- a/xen/include/public/arch-x86/xen.h
>>> +++ b/xen/include/public/arch-x86/xen.h
>>> @@ -263,7 +263,7 @@ struct arch_shared_info {
>>>   typedef struct arch_shared_info arch_shared_info_t;
>>>
>>>   struct xen_arch_domainconfig {
>>> -    char dummy;
>>> +    uint64_t vmware_hwver;
>>
>> Julien: (as the author of the introducing patch) Given that this
>> structure is used as part of a domain_create hypercall only, I think a
>> comment is warrented stating that its API/ABI is covered by the
>> DOMCTL_INTERFACE_VERSION.
> 
> It's part of DOMCTL_INTERFACE_VERSION. Feel free to send a patch to add 
> a comment.
> 
>> Strictly speaking, this is currently part of the public ABI which must
>> always maintain backwards compatibility.
> 
> I don't think it's necessary to maintain backwards compatibility.  This 
> has been added during this is release cycle.
> 
>> Don:  Feel free to retain my Reviewed-by, subject to the adjustments listed.
> 
> It's rather strange to have a separate patch for adding vmware_hwver 
> version in the tools.

That was done to reduce the size of the patches.

> You are relying on the fact that the toolstack 
> memset zero xen_arch_domainconfig to zero which is hidden in the maze of 
> the code (the memset is done on an upper container).
> 
> It would be worth to add an explicit vmware_hwver = 0 in the 
> libxl__arch_domain_prepare_config.
> 

Ok, I will do so (the next patch does change this code).  This does add
a requirement of a tools ack to this patch.

   -Don Slutz

> Regards,
>