* [Cocci] [PATCH 1/2 RESEND] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood @ 2015-05-20 11:02 Fabio Estevam 2015-05-20 11:02 ` [Cocci] [PATCH 2/2 RESEND] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar Fabio Estevam 0 siblings, 1 reply; 3+ messages in thread From: Fabio Estevam @ 2015-05-20 11:02 UTC (permalink / raw) To: cocci From: Fabio Estevam <fabio.estevam@freescale.com> According to Documentation/SubmittingPatches: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. So do as recommended. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> --- scripts/coccinelle/misc/semicolon.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccinelle/misc/semicolon.cocci b/scripts/coccinelle/misc/semicolon.cocci index a47eba2..6740c65 100644 --- a/scripts/coccinelle/misc/semicolon.cocci +++ b/scripts/coccinelle/misc/semicolon.cocci @@ -1,5 +1,5 @@ /// -/// Removes unneeded semicolon. +/// Remove unneeded semicolon. /// // Confidence: Moderate // Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2. -- 1.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Cocci] [PATCH 2/2 RESEND] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar 2015-05-20 11:02 [Cocci] [PATCH 1/2 RESEND] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood Fabio Estevam @ 2015-05-20 11:02 ` Fabio Estevam 2015-05-21 6:19 ` Michal Marek 0 siblings, 1 reply; 3+ messages in thread From: Fabio Estevam @ 2015-05-20 11:02 UTC (permalink / raw) To: cocci From: Fabio Estevam <fabio.estevam@freescale.com> Correct form is 'always requested'. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> --- scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci index a24a754..b17ac8b 100644 --- a/scripts/coccinelle/misc/irqf_oneshot.cocci +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci @@ -1,4 +1,4 @@ -/// Make sure threaded IRQs without a primary handler are always request with +/// Make sure threaded IRQs without a primary handler are always requested with /// IRQF_ONESHOT /// // -- 1.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Cocci] [PATCH 2/2 RESEND] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar 2015-05-20 11:02 ` [Cocci] [PATCH 2/2 RESEND] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar Fabio Estevam @ 2015-05-21 6:19 ` Michal Marek 0 siblings, 0 replies; 3+ messages in thread From: Michal Marek @ 2015-05-21 6:19 UTC (permalink / raw) To: cocci Dne 20.5.2015 v 19:02 Fabio Estevam napsal(a): > From: Fabio Estevam <fabio.estevam@freescale.com> > > Correct form is 'always requested'. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied these two, thanks. Michal ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-21 6:19 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-20 11:02 [Cocci] [PATCH 1/2 RESEND] scripts/coccinelle/misc/semicolon.cocci: Use imperative mood Fabio Estevam 2015-05-20 11:02 ` [Cocci] [PATCH 2/2 RESEND] scripts/coccinelle/misc/irqf_oneshot.cocci: Fix grammar Fabio Estevam 2015-05-21 6:19 ` Michal Marek
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.