From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48630)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1YvN4Z-00010E-DW
	for qemu-devel@nongnu.org; Thu, 21 May 2015 05:47:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1YvN4U-0006Zj-Fv
	for qemu-devel@nongnu.org; Thu, 21 May 2015 05:47:27 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:28373)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Yongbok.Kim@imgtec.com>) id 1YvN4U-0006ZP-B1
	for qemu-devel@nongnu.org; Thu, 21 May 2015 05:47:22 -0400
Message-ID: <555DA9A9.7030407@imgtec.com>
Date: Thu, 21 May 2015 10:47:21 +0100
From: Yongbok Kim <yongbok.kim@imgtec.com>
MIME-Version: 1.0
References: <1432134765-7680-1-git-send-email-yongbok.kim@imgtec.com>
	<1432134765-7680-4-git-send-email-yongbok.kim@imgtec.com>
	<555CC394.5080501@twiddle.net>
In-Reply-To: <555CC394.5080501@twiddle.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory
	accesses for MSA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, leon.alrae@imgtec.com, afaerber@suse.de

On 20/05/2015 18:25, Richard Henderson wrote:

> 
>> +    int i;                                                              \
>> +    for (i = 0; i < DF_ELEMENTS(DF); i++) {                             \
>> +        wx.TYPE[i] = LD_INSN(env, addr + (i << DF), ##__VA_ARGS__);     \
> 
> Why the varargs?  They're the same all the time.

No, they aren't. we still need to support linux user mode which don't have
any extra argument.

MSA_LD_DF(DF_BYTE,   b, helper_ret_ldub_mmu, \
          make_memop_idx(MO_UNALN, cpu_mmu_index(env)), GETRA())

VS.

MSA_LD_DF(DF_BYTE,   b, cpu_ldub_data)


Regards,
Yongbok