From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v9 1/6] tools/libxl: Check if fdt_{first, next}_subnode are present in libfdt Date: Thu, 21 May 2015 15:25:27 +0100 Message-ID: <555DEAD7.9090106@citrix.com> References: <1431542022-16138-1-git-send-email-julien.grall@citrix.com> <1431542022-16138-2-git-send-email-julien.grall@citrix.com> <555C8524.6010403@citrix.com> <1432217599.10746.36.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YvRwB-0005WE-5f for xen-devel@lists.xenproject.org; Thu, 21 May 2015 14:59:07 +0000 In-Reply-To: <1432217599.10746.36.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: Wei Liu , Ian Jackson , Julien Grall , tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 21/05/15 15:13, Ian Campbell wrote: > On Wed, 2015-05-20 at 13:59 +0100, Julien Grall wrote: >> [...] >> From d4f0ea84f26649b61bc6afb550348069b71d41c5 Mon Sep 17 00:00:00 2001 >> From: Julien Grall >> Date: Tue, 17 Mar 2015 17:58:14 +0000 >> Subject: [PATCH] tools/libxl: Check if fdt_{first,next}_subnode are present in >> libfdt >> >> The functions fdt_{first,next}_subnode may not be available because: >> * It has been introduced in 2013 => Doesn't work on Wheezy >> * The prototype exists but the functions are not exposed. Don't ask >> why... >> >> The later has been fixed recently in the dtc repo [1] > > But the bug is still present in 1.4.0, right? Hence this patch is not > obsolete even given the next one. It is present until 1.4.1. The changes will be on the next released of libfdt. The commit may be useful for people building there own libfdt. Regards, -- Julien Grall