From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57921)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YvT9N-0007MR-VQ
	for qemu-devel@nongnu.org; Thu, 21 May 2015 12:16:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YvT9J-000332-6R
	for qemu-devel@nongnu.org; Thu, 21 May 2015 12:16:49 -0400
Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:36545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YvT9J-00032v-1y
	for qemu-devel@nongnu.org; Thu, 21 May 2015 12:16:45 -0400
Received: by qkx62 with SMTP id 62so12041110qkx.3
	for <qemu-devel@nongnu.org>; Thu, 21 May 2015 09:16:44 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <555E04E8.9040806@twiddle.net>
Date: Thu, 21 May 2015 09:16:40 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1432134765-7680-1-git-send-email-yongbok.kim@imgtec.com>
	<1432134765-7680-4-git-send-email-yongbok.kim@imgtec.com>
	<555CC394.5080501@twiddle.net> <555DA9A9.7030407@imgtec.com>
In-Reply-To: <555DA9A9.7030407@imgtec.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 3/3] target-mips: Misaligned memory
	accesses for MSA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yongbok Kim <yongbok.kim@imgtec.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, leon.alrae@imgtec.com, afaerber@suse.de

On 05/21/2015 02:47 AM, Yongbok Kim wrote:
> On 20/05/2015 18:25, Richard Henderson wrote:
> 
>>
>>> +    int i;                                                              \
>>> +    for (i = 0; i < DF_ELEMENTS(DF); i++) {                             \
>>> +        wx.TYPE[i] = LD_INSN(env, addr + (i << DF), ##__VA_ARGS__);     \
>>
>> Why the varargs?  They're the same all the time.
> 
> No, they aren't. we still need to support linux user mode which don't have
> any extra argument.
> 
> MSA_LD_DF(DF_BYTE,   b, helper_ret_ldub_mmu, \
>           make_memop_idx(MO_UNALN, cpu_mmu_index(env)), GETRA())
> 
> VS.
> 
> MSA_LD_DF(DF_BYTE,   b, cpu_ldub_data)

Ah, I'd missed that.  Thanks,


r~