From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvU9T-00073P-No for qemu-devel@nongnu.org; Thu, 21 May 2015 13:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvU9N-0001lu-H1 for qemu-devel@nongnu.org; Thu, 21 May 2015 13:20:59 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:33207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvU9N-0001lb-D7 for qemu-devel@nongnu.org; Thu, 21 May 2015 13:20:53 -0400 Received: by qgfa63 with SMTP id a63so24982952qgf.0 for ; Thu, 21 May 2015 10:20:53 -0700 (PDT) Sender: Richard Henderson Message-ID: <555E13F1.5080500@twiddle.net> Date: Thu, 21 May 2015 10:20:49 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1431510311-13355-1-git-send-email-kbastian@mail.uni-paderborn.de> <1431510311-13355-4-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1431510311-13355-4-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/10] target-tricore: Add SRC_MOV_E instruction of the v1.6 ISA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 05/13/2015 02:45 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > --- > target-tricore/translate.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson > + case OPC1_16_SRC_MOV_E: > + if (tricore_feature(env, TRICORE_FEATURE_16)) { > + tcg_gen_movi_tl(cpu_gpr_d[r1], const4); > + tcg_gen_sari_tl(cpu_gpr_d[r1+1], cpu_gpr_d[r1], 31); You could sign-extend here at translation time, but it's also true that the optimizer will handle this. r~