Re: [Qemu-devel] [PATCH v2] tcg: fix dead computation for repeated input arguments

[Richard Henderson <rth@twiddle.net>]

On 05/21/2015 12:35 PM, Aurelien Jarno wrote:
> When the same temp is used twice or more as an input argument to a TCG
> instruction, the dead computation code doesn't recognize the second use
> as a dead temp. This is because the temp is marked as live in the same
> loop where dead inputs are checked.
> 
> The fix is to split the loop in two parts. This avoid emitting a move
> and using a register for the movcond instruction when used as "move if
> true" on x86-64. This might bring more improvements on RISC TCG targets
> which don't have outputs aliased to inputs.
> 
> Cc: Richard Henderson <rth@twiddle.net>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  tcg/tcg.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~