From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/shadow: fix uninitialized rc
	shadow_track_dirty_vram()
Date: Fri, 22 May 2015 08:41:48 +0100
Message-ID: <555EDDBC.5030301@citrix.com>
References: <555EE8D2020000780007D03A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <amc96@hermes.cam.ac.uk>) id 1YvhaW-0006GN-FS
	for xen-devel@lists.xenproject.org; Fri, 22 May 2015 07:41:48 +0000
In-Reply-To: <555EE8D2020000780007D03A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Tim Deegan <tim@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 22/05/2015 07:29, Jan Beulich wrote:
> Commit bd1b4a71b3 ("x86/shadow: fix shadow_track_dirty_vram to work on
> hvm guests"), trying to mirror its HAP counterpart, deleted a couple of
> assignments to rc without making sure rc is initialized on all paths.
>
> Coverity ID: 1299410
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -3518,7 +3518,7 @@ int shadow_track_dirty_vram(struct domain
>                              unsigned long nr,
>                              XEN_GUEST_HANDLE_64(uint8) guest_dirty_bitmap)
>  {
> -    int rc;
> +    int rc = 0;
>      unsigned long end_pfn = begin_pfn + nr;
>      unsigned long dirty_size = (nr + 7) / 8;
>      int flush_tlb = 0;
> @@ -3550,10 +3550,7 @@ int shadow_track_dirty_vram(struct domain
>      }
>  
>      if ( !nr )
> -    {
> -        rc = 0;
>          goto out;
> -    }
>  
>      dirty_bitmap = vzalloc(dirty_size);
>      if ( dirty_bitmap == NULL )
>
>
>