From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 22 May 2015 10:32:00 +0200 (CEST) Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:46996 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006535AbbEVIb7JUwsG (ORCPT ); Fri, 22 May 2015 10:31:59 +0200 X-IronPort-AV: E=Sophos;i="5.13,474,1427785200"; d="scan'208";a="65543231" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw2-out.broadcom.com with ESMTP; 22 May 2015 01:42:25 -0700 Received: from IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.235.1; Fri, 22 May 2015 01:31:48 -0700 Received: from mail-sj1-12.sj.broadcom.com (10.10.10.20) by IRVEXCHSMTP3.corp.ad.broadcom.com (10.9.207.53) with Microsoft SMTP Server id 14.3.235.1; Fri, 22 May 2015 01:31:48 -0700 Received: from [10.176.128.60] (xl-bun-02.bun.broadcom.com [10.176.128.60]) by mail-sj1-12.sj.broadcom.com (Postfix) with ESMTP id 76D1D27A82; Fri, 22 May 2015 01:31:47 -0700 (PDT) Message-ID: <555EE972.7040801@broadcom.com> Date: Fri, 22 May 2015 10:31:46 +0200 From: Arend van Spriel User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.24) Gecko/20111103 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= CC: Kalle Valo , linux-wireless , Hante Meuleman , "linux-mips@linux-mips.org" Subject: Re: [PATCH 6/6] brcmfmac: Add support for host platform NVRAM loading. References: <1432123792-4155-1-git-send-email-arend@broadcom.com> <1432123792-4155-7-git-send-email-arend@broadcom.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 47547 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: arend@broadcom.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips The patch is dropped, but I still owe you a response to this. I missed it because you sent 2 or 3 replies confusing me. On 05/20/15 17:02, Rafał Miłecki wrote: > On 20 May 2015 at 14:09, Arend van Spriel wrote: >> @@ -139,11 +165,11 @@ brcmf_nvram_handle_value(struct nvram_parser *nvp) >> char *ekv; >> u32 cplen; >> >> - c = nvp->fwnv->data[nvp->pos]; >> - if (!is_nvram_char(c)) { >> + c = nvp->data[nvp->pos]; >> + if (!is_nvram_char(c)&& (c != ' ')) { > > Don't smuggle behavior changes in patches doing something else! The subject is "Add support for host platform NVRAM loading" and guess what. That type of NVRAM turned out to have spaces in the entries so in my opinion it is related to this patch. I can split it up if you feel strongly about this. >> @@ -406,19 +434,34 @@ static void brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx) >> struct brcmf_fw *fwctx = ctx; >> u32 nvram_length = 0; >> void *nvram = NULL; >> + u8 *data = NULL; >> + size_t data_len; >> + bool raw_nvram; >> >> brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(fwctx->dev)); >> - if (!fw&& !(fwctx->flags& BRCMF_FW_REQ_NV_OPTIONAL)) >> - goto fail; >> + if ((fw)&& (fw->data)) { > > if (fw&& fw->data) > will work just fine, I'm surprised checkpatch doesn't complain. I ran checkpatch.pl --strict and did not get complaint about this change. Regards, Arend