From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: Use ULL for GB macro Date: Fri, 22 May 2015 10:37:05 +0100 Message-ID: <555EF8C1.2050505@citrix.com> References: <1432250206-30484-1-git-send-email-julien.grall@citrix.com> <555EEE75020000780007D064@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YvjOA-0001qX-SU for xen-devel@lists.xenproject.org; Fri, 22 May 2015 09:37:10 +0000 In-Reply-To: <555EEE75020000780007D064@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, keir@xen.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org Hi Jan, On 22/05/2015 07:53, Jan Beulich wrote: >>>> On 22.05.15 at 01:16, wrote: >> --- a/xen/arch/x86/apic.c >> +++ b/xen/arch/x86/apic.c >> @@ -992,7 +992,7 @@ void __init init_apic_mappings(void) >> apic_phys = mp_lapic_addr; >> >> set_fixmap_nocache(FIX_APIC_BASE, apic_phys); >> - apic_printk(APIC_VERBOSE, "mapped APIC to %08lx (%08lx)\n", APIC_BASE, >> + apic_printk(APIC_VERBOSE, "mapped APIC to %08llx (%08lx)\n", APIC_BASE, > > Please use 'L' as the shorter equivalent. I didn't know this shorthand. I will use %Lx > >> --- a/xen/include/xen/config.h >> +++ b/xen/include/xen/config.h >> @@ -70,7 +70,7 @@ >> #define __bitwise >> >> #define MB(_mb) (_AC(_mb, UL) << 20) >> -#define GB(_gb) (_AC(_gb, UL) << 30) >> +#define GB(_gb) (_AC(_gb, ULL) << 30) > > So why do you leave MB() alone? It obviously suffers from the same > problem (perhaps only latent at this point, but anyway). Because I haven't had any problem with MB. I will resend a new version with the 2 fixes. Regards, -- Julien Grall