From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC][v2][PATCH 07/14] xen/passthrough: extend hypercall to support rdm reservation policy Date: Fri, 22 May 2015 11:33:57 +0100 Message-ID: <555F0615.8030809@citrix.com> References: <1432287314-4388-1-git-send-email-tiejun.chen@intel.com> <1432287314-4388-8-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432287314-4388-8-git-send-email-tiejun.chen@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen , JBeulich@suse.com, tim@xen.org, konrad.wilk@oracle.com, andrew.cooper3@citrix.com, kevin.tian@intel.com, yang.z.zhang@intel.com, ian.campbell@citrix.com, wei.liu2@citrix.com, Ian.Jackson@eu.citrix.com, stefano.stabellini@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi, On 22/05/2015 10:35, Tiejun Chen wrote: > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index 0c0ea4a..203c80e 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -499,6 +499,11 @@ struct xen_domctl_assign_device { > XEN_GUEST_HANDLE_64(char) path; /* path to the device tree node */ > } dt; > } u; > + /* IN */ > +#define XEN_DOMCTL_DEV_NO_RDM 0 > +#define XEN_DOMCTL_DEV_RDM_RELAXED 1 > +#define XEN_DOMCTL_DEV_RDM_STRICT 2 > + uint32_t flag; /* flag of assigned device */ You don't plumb this value for DT neither in the toolstack (see xc_assign_dt_device) and Xen. Please add a comment saying it's only used by PCI and/or the value should always be XEN_DOMCTL_DEV_NO_RDM for DT. Regards, -- -- Julien Grall