From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org ([54.187.51.154]:52649 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756283AbbEVKkJ (ORCPT ); Fri, 22 May 2015 06:40:09 -0400 Message-ID: <555F0785.9030403@osg.samsung.com> Date: Fri, 22 May 2015 12:40:05 +0200 From: Stefan Schmidt MIME-Version: 1.0 Subject: Re: [PATCH bluetooth-next 4/4] mac802154: use atomic ops for sequence incrementation References: <1432285031-3360-1-git-send-email-alex.aring@gmail.com> <1432285031-3360-5-git-send-email-alex.aring@gmail.com> <555EEFF1.90603@pengutronix.de> <555F0560.8060805@osg.samsung.com> <555F062B.3010107@pengutronix.de> In-Reply-To: <555F062B.3010107@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde , Alexander Aring , linux-wpan@vger.kernel.org Cc: kernel@pengutronix.de Hello. On 22/05/15 12:34, Marc Kleine-Budde wrote: > On 05/22/2015 12:30 PM, Stefan Schmidt wrote: >> Hello. >> >> On 22/05/15 10:59, Marc Kleine-Budde wrote: >>> On 05/22/2015 10:57 AM, Alexander Aring wrote: >>>> This patch will use atomic operations for sequence number incrementation >>>> while MAC header generation. Upper layers like af_802154 or 6LoWPAN >>>> could call this function in a parallel context while generating 802.15.4 >>>> MAC header before queuing into wpan interfaces transmit queue. >>> what about swapping patch 3 and 4? >> To avoid having problems during a git bisect later one? E.g. having the >> lock removed but no atomic in place? > Yes, that's what I was thinking about. I don't know the code to tell if > this is an issue here. A good point. I'm not sure either. I would say we could play safe and swap them. Alex, guess its your final call as you know the code best from us. Could we have problems with the locks removed but the atomic patch not applied (as it could happen with git bisect right now)? If yes, swapping them makes sense to avoid this. Btw, I'm running some light testing with 6lowpan pings with these four patches applied right now. Looks good so far. Will send another mail once its done. regards Stefan Schmidt