From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH V4] xen/vm_event: Clean up
	control-register-write vm_events
Date: Fri, 22 May 2015 15:45:04 +0300
Message-ID: <555F24D0.3040705@bitdefender.com>
References: <1432213223-5211-1-git-send-email-rcojocaru@bitdefender.com>
	<555EF8AA020000780007D0A9@mail.emea.novell.com>
	<555F1DFF.6080700@bitdefender.com>
	<555F3BB8020000780007D43D@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <555F3BB8020000780007D43D@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, keir@xen.org, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 05/22/2015 03:22 PM, Jan Beulich wrote:
>>>> On 22.05.15 at 14:15, <rcojocaru@bitdefender.com> wrote:
>> While working on this I found the following in the vm_event.h header:
>>
>> 168 struct vm_event_debug {
>> 169     uint64_t gfn;
>> 170     uint32_t _pad;
>> 171 };
>>
>> Is this supposed to be 64 + 32 bits padding?
> 
> I think I need to direct the question back to you.

Fair enough, let me rephrase that: I don't see how that padding would be
useful, and I propose to remove _pad as part of the next version of this
patch (or a different smaller patch).


Thanks,
Razvan