Re: [PATCH 4/6] vhost: Add new command line option: rxq

[Thomas F Herbert <therbert@redhat.com>]

On 5/22/15 2:05 AM, Ouyang, Changchun wrote:
> Hi Thomas,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas F Herbert
>> Sent: Friday, May 22, 2015 9:39 AM
>> To: dpdk >> dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 4/6] vhost: Add new command line option:
>> rxq
>>
>>
>>
>> On 5/21/15 3:49 AM, Ouyang Changchun wrote:
>>> Sample vhost need know the queue number user want to enable for each
>>> virtio device, so add the new option '--rxq' into it.
>> Could you also add the new --rxq option description to us_vhost_usage()?
>
> Actually we have, please see below
True enough. However, the code calls rte_eal_init() before parsing args 
and therefore takes rte_exit before printing usage of the non-eal options.
>
>> +585,8 @@
>>> us_vhost_usage(const char *prgname)
>>>    	"		--rx-desc-num [0-N]: the number of descriptors on rx,
>> "
>>>    			"used only when zero copy is enabled.\n"
>>>    	"		--tx-desc-num [0-N]: the number of descriptors on tx,
>> "
>>> -			"used only when zero copy is enabled.\n",
>>> +			"used only when zero copy is enabled.\n"
>>> +	"		--rxq [1,2,4]: rx queue number for each vhost
>> device\n",
>>>    	       prgname);
>>>    }
>
> Thanks
> Changchun
>