From: Stanislav Brabec <sbrabec@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Fix /sys to /dev node name translation
Date: Fri, 22 May 2015 15:52:29 +0200 [thread overview]
Message-ID: <555F349D.7080706@suse.cz> (raw)
In-Reply-To: <20150521111134.GB4730@ws.net.home>
Karel Zak wrote:
> I hope we use lib/sysfs.c code always when possible. It should be
> possible to detect all /sys code by
>
> git grep _PATH_SYS_
>
> so
>
> disk-utils/partx.c
> lib/loopdev.c
> lib/sysfs.c
> libblkid/src/devname.c
> misc-utils/lsblk.c
>
I went through these files and none of them seems to do such conversion.
So only the three places in the last patch needs to be fixed.
I already have a new patch introducing static inline void
sysfs_devname_to_dev_name (char *name) helper for in-place conversion of
'!' to '/', but I am waiting for a chance to make a test on a real
hardware next week.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
Lihovarská 1060/12 tel: +49 911 7405384547
190 00 Praha 9 fax: +420 284 084 001
Czech Republic http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76
next prev parent reply other threads:[~2015-05-22 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 19:31 [PATCH] Fix /sys to /dev node name translation Stanislav Brabec
2015-05-19 8:08 ` Karel Zak
2015-05-19 12:35 ` Stanislav Brabec
2015-05-21 11:11 ` Karel Zak
2015-05-22 13:52 ` Stanislav Brabec [this message]
2015-05-25 16:21 ` Stanislav Brabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F349D.7080706@suse.cz \
--to=sbrabec@suse.cz \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.