Re: [Qemu-devel] [PULL v2 00/18] target-alpha fpu improvements

[Richard Henderson <rth@twiddle.net>]

On 05/22/2015 04:32 AM, Peter Maydell wrote:
> On 22 May 2015 at 11:22, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 22 May 2015 at 11:00, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> On 21 May 2015 at 18:39, Richard Henderson <rth@twiddle.net> wrote:
>>>> for you to fetch changes up to 32ad48abd74a997220b841e4e913edeb267aa362:
>>>>
>>>>   target-alpha: Add vector implementation for CMPBGE (2015-05-21 10:34:18 -0700)
>>>
>>> Applied, thanks.
>>
>> Except I failed to notice a test failure from one of my builds
>> before pushing:
>>
>> target-alpha/int_helper.c: In function 'helper_cmpbge':
>> target-alpha/int_helper.c:77: error: invalid operands to binary >=
>> target-alpha/int_helper.c:79: error: subscripted value is neither
>> array nor pointer
>>
>> That's in the Centos5 build, which is
>> gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
>>
>> Any suggestions?
>>
>> I do note that this build target is basically obsolete anyway, because
>> we're about to move to requiring glib 2.22, at which point Centos5 is
>> officially Too Old. So maybe we just say "yeah, you need a newer gcc" ?
> 
> Hmm. This fails on some of the travis builds too, with slightly
> different warnings:
> 
> gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
> target-alpha/int_helper.c:77:24: error: invalid operands to binary >=
> (have '__vector(16) unsigned char' and '__vector(16) unsigned char')
> 
> I think the best thing to do for the moment is to revert commit
> 32ad48abd74a9 so we can get trunk building again, so I'm going to
> do that.

Wow, I would have thought 4.6 would have been new enough.
Sorry for the headache.  Yes, a revert is probably best
until I can figure out what versions do what.


r~